Commit 1074d74c authored by Bettina Dea's avatar Bettina Dea Committed by Commit Bot

Revert "Log metric when password is first signed in."

This reverts commit 8c91b029.

Reason for revert: Only want to log this metric on startup to keep
metric simple.

Original change's description:
> Log metric when password is first signed in.
> 
> Previously, SaveProtectedPasswordHash did not log
> a metric when a password is saved into the hash
> manager on first signed in.
> 
> Bug: 1032322
> Change-Id: I66fca65496ccd5866536d954f60e4773d66d3a4d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959046
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Commit-Queue: Bettina Dea <bdea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#723508}

TBR=vasilii@chromium.org,vakh@chromium.org,bdea@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1032322
Change-Id: Ida2a7b78027b392702c79fa6fd613b827567723e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963209Reviewed-by: default avatarBettina Dea <bdea@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724045}
parent 42524597
...@@ -490,8 +490,6 @@ void PasswordStore::SaveProtectedPasswordHash(const std::string& username, ...@@ -490,8 +490,6 @@ void PasswordStore::SaveProtectedPasswordHash(const std::string& username,
const base::string16& password, const base::string16& password,
bool is_gaia_password, bool is_gaia_password,
GaiaPasswordHashChange event) { GaiaPasswordHashChange event) {
bool is_first_sign_in =
!hash_password_manager_.HasPasswordHash(username, is_gaia_password);
if (hash_password_manager_.SavePasswordHash(username, password, if (hash_password_manager_.SavePasswordHash(username, password,
is_gaia_password)) { is_gaia_password)) {
bool is_syncing = bool is_syncing =
...@@ -500,8 +498,7 @@ void PasswordStore::SaveProtectedPasswordHash(const std::string& username, ...@@ -500,8 +498,7 @@ void PasswordStore::SaveProtectedPasswordHash(const std::string& username,
if (is_gaia_password) { if (is_gaia_password) {
metrics_util::LogGaiaPasswordHashChange(event, is_syncing); metrics_util::LogGaiaPasswordHashChange(event, is_syncing);
} }
// Should log metrics if this is the first time saving the password hash. SchedulePasswordHashUpdate(/*should_log_metrics=*/false);
SchedulePasswordHashUpdate(/*should_log_metrics=*/is_first_sign_in);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment