Commit 10752e4f authored by Philip Rogers's avatar Philip Rogers Committed by Commit Bot

[BlinkGenPropertyTrees] Run DocumentAnimations::UpdateAnimations for svg

This patch runs DocumentAnimations::UpdateAnimations for svg images,
matching the SPV2 codepath. The corresponding non-svg-image
UpdateAnimations call is behind a SPV2 || BGPT conditional in
local_frame_view.cc.

Bug: 854198
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If5132139cb7dcf0add0227c189f73809933a20c3
Reviewed-on: https://chromium-review.googlesource.com/1107098Reviewed-by: default avatarTien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568669}
parent 21fbf9f3
......@@ -647,7 +647,3 @@ crbug.com/854196 paint/invalidation/compositing/should-not-repaint-composited-de
crbug.com/854196 paint/invalidation/compositing/should-not-repaint-composited-descendants.html [ Failure ]
crbug.com/854196 paint/invalidation/scroll/overflow-scroll-composited-non-stacking-child.html [ Failure ]
crbug.com/854196 paint/invalidation/scroll/repaint-composited-child-in-scrolled-container.html [ Failure ]
# Animated SVG images do not work.
crbug.com/854198 paint/invalidation/svg/image-animation-with-zoom.html [ Failure ]
crbug.com/854198 svg/as-image/svg-image-with-css-animation.html [ Failure ]
......@@ -636,11 +636,12 @@ void SVGImage::ServiceAnimations(
LocalFrameView* frame_view = ToLocalFrame(page_->MainFrame())->View();
frame_view->UpdateAllLifecyclePhasesExceptPaint();
if (RuntimeEnabledFeatures::SlimmingPaintV2Enabled()) {
// For SPv2 we run UpdateAnimations after the paint phase, but per above
// comment we don't want to run lifecycle through to paint for SVG images.
// Since we know SVG images never have composited animations we can update
// animations directly without worrying about including
if (RuntimeEnabledFeatures::SlimmingPaintV2Enabled() ||
RuntimeEnabledFeatures::BlinkGenPropertyTreesEnabled()) {
// For SPv2/BGPT we run UpdateAnimations after the paint phase, but per the
// above comment, we don't want to run lifecycle through to paint for SVG
// images. Since we know SVG images never have composited animations we can
// update animations directly without worrying about including
// PaintArtifactCompositor analysis of whether animations should be
// composited.
base::Optional<CompositorElementIdSet> composited_element_ids;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment