use AttestationClient to create certificate request.
We are deprecating attestation methods by CryptohomeClient. This is the minimum change for chromium-side attestation flow to support ECC key type. As for implementation details, it is chosen to let the AttestationFlow object to hold a constant key type instead of being flexible when calling GetCertificate. The reasons are 1., we don't have the needs to specify key type with a single attestation flow instance, and it requires the key type passing through almost the entire attestation flow. It implied more code change, but also implies impact to readability because we already use "key type" terminology to refers to the type of EMK/EUK in this class; more presence of overloaded "key type" is not easy for readers. BUG=b:158955123 TEST=unit_tests. Change-Id: Iab3cdd0b943219765ec7b99626cba53c382ce6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474933 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#820615}
Showing
This diff is collapsed.
Please register or sign in to comment