Inline static Create() factory functions from renderer/core

This CL removes unnecessary Create() factory functions in
//third_partyb/blink/renderer/core only when it
meets the policy of removing Create() so that we support
only one of Create() methods or public constructors in a class.
Then, this CL makes all callers use MakeGarbageCollected<Foo>
instead.

This CL removes below Create() functions,
  - InsertIncrementalTextCommand::Create
  - InspectorStyleSheetForInlineStyle::Create
  - NetworkResourcesData::Create

Bug: 939691
Change-Id: I003a97c5dfe37f780f25af9f9a36138cffb76a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980525Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#727294}

third_party/blink/renderer/core/editing/commands/insert_incremental_text_command.cc

@@ -118,14 +118,6 @@ SelectionInDOMTree ComputeSelectionForInsertion(
 
 }  // anonymous namespace
 
-InsertIncrementalTextCommand* InsertIncrementalTextCommand::Create(
-    Document& document,
-    const String& text,
-    RebalanceType rebalance_type) {
-  return MakeGarbageCollected<InsertIncrementalTextCommand>(document, text,
-                                                            rebalance_type);
-}
-
 InsertIncrementalTextCommand::InsertIncrementalTextCommand(
     Document& document,
     const String& text,

third_party/blink/renderer/core/editing/commands/insert_incremental_text_command.h

@@ -12,15 +12,11 @@ namespace blink {
 class CORE_EXPORT InsertIncrementalTextCommand final
     : public InsertTextCommand {
  public:
-  static InsertIncrementalTextCommand* Create(
+  InsertIncrementalTextCommand(
       Document&,
-      const String&,
+      const String& text,
       RebalanceType = kRebalanceLeadingAndTrailingWhitespaces);
 
-  InsertIncrementalTextCommand(Document&,
-                               const String& text,
-                               RebalanceType);
-
  private:
   void DoApply(EditingState*) override;
 };

third_party/blink/renderer/core/editing/commands/insert_incremental_text_command_test.cc

@@ -7,6 +7,7 @@
 #include "third_party/blink/renderer/core/editing/frame_selection.h"
 #include "third_party/blink/renderer/core/editing/selection_template.h"
 #include "third_party/blink/renderer/core/editing/testing/editing_test_base.h"
+#include "third_party/blink/renderer/platform/heap/heap.h"
 
 namespace blink {
 
@@ -23,7 +24,8 @@ TEST_F(InsertIncrementalTextCommandTest, SurrogatePairsReplace) {
                                .Build(),
                            SetSelectionOptions());
   CompositeEditCommand* const command =
-      InsertIncrementalTextCommand::Create(GetDocument(), new_text);
+      MakeGarbageCollected<InsertIncrementalTextCommand>(GetDocument(),
+                                                         new_text);
   command->Apply();
 
   EXPECT_EQ(String(Vector<UChar>{'b', 0xD83D, 0xDE38}),
@@ -41,7 +43,8 @@ TEST_F(InsertIncrementalTextCommandTest, SurrogatePairsNoReplace) {
                                .Build(),
                            SetSelectionOptions());
   CompositeEditCommand* const command =
-      InsertIncrementalTextCommand::Create(GetDocument(), new_text);
+      MakeGarbageCollected<InsertIncrementalTextCommand>(GetDocument(),
+                                                         new_text);
   command->Apply();
 
   EXPECT_EQ(String(Vector<UChar>{'b', 0xD83D, 0xDE3A}),
@@ -61,7 +64,8 @@ TEST_F(InsertIncrementalTextCommandTest, SurrogatePairsTwo) {
                                .Build(),
                            SetSelectionOptions());
   CompositeEditCommand* const command =
-      InsertIncrementalTextCommand::Create(GetDocument(), new_text);
+      MakeGarbageCollected<InsertIncrementalTextCommand>(GetDocument(),
+                                                         new_text);
   command->Apply();
 
   EXPECT_EQ(String(Vector<UChar>{'b', 0xD83D, 0xDE38}),

third_party/blink/renderer/core/editing/commands/typing_command.cc

@@ -663,7 +663,7 @@ void TypingCommand::InsertTextRunWithoutNewlines(const String& text,
                                                  EditingState* editing_state) {
   CompositeEditCommand* command;
   if (IsIncrementalInsertion()) {
-    command = InsertIncrementalTextCommand::Create(
+    command = MakeGarbageCollected<InsertIncrementalTextCommand>(
         GetDocument(), text,
         composition_type_ == kTextCompositionNone
             ? InsertIncrementalTextCommand::

third_party/blink/renderer/core/inspector/inspector_css_agent.cc

@@ -1832,7 +1832,7 @@ InspectorStyleSheetForInlineStyle* InspectorCSSAgent::AsInspectorStyleSheet(
     return nullptr;
 
   InspectorStyleSheetForInlineStyle* inspector_style_sheet =
-      InspectorStyleSheetForInlineStyle::Create(element, this);
+      MakeGarbageCollected<InspectorStyleSheetForInlineStyle>(element, this);
   id_to_inspector_style_sheet_for_inline_style_.Set(inspector_style_sheet->Id(),
                                                     inspector_style_sheet);
   node_to_inspector_style_sheet_.Set(element, inspector_style_sheet);

third_party/blink/renderer/core/inspector/inspector_network_agent.cc

@@ -1702,8 +1702,9 @@ InspectorNetworkAgent::InspectorNetworkAgent(
     : inspected_frames_(inspected_frames),
       worker_global_scope_(worker_global_scope),
       v8_session_(v8_session),
-      resources_data_(NetworkResourcesData::Create(kDefaultTotalBufferSize,
-                                                   kDefaultResourceBufferSize)),
+      resources_data_(MakeGarbageCollected<NetworkResourcesData>(
+          kDefaultTotalBufferSize,
+          kDefaultResourceBufferSize)),
       devtools_token_(worker_global_scope_
                           ? worker_global_scope_->GetParentDevToolsToken()
                           : inspected_frames->Root()->GetDevToolsFrameToken()),

third_party/blink/renderer/core/inspector/inspector_style_sheet.cc

@@ -1906,13 +1906,6 @@ bool InspectorStyleSheet::InspectorStyleSheetText(String* result) {
   return true;
 }
 
-InspectorStyleSheetForInlineStyle* InspectorStyleSheetForInlineStyle::Create(
-    Element* element,
-    Listener* listener) {
-  return MakeGarbageCollected<InspectorStyleSheetForInlineStyle>(element,
-                                                                 listener);
-}
-
 InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle(
     Element* element,
     Listener* listener)

third_party/blink/renderer/core/inspector/inspector_style_sheet.h

@@ -241,8 +241,6 @@ class InspectorStyleSheet : public InspectorStyleSheetBase {
 
 class InspectorStyleSheetForInlineStyle final : public InspectorStyleSheetBase {
  public:
-  static InspectorStyleSheetForInlineStyle* Create(Element*, Listener*);
-
   InspectorStyleSheetForInlineStyle(Element*, Listener*);
   void DidModifyElementAttribute();
   bool SetText(const String&, ExceptionState&) override;

third_party/blink/renderer/core/inspector/network_resources_data.h

@@ -202,12 +202,6 @@ class NetworkResourcesData final
     scoped_refptr<EncodedFormData> post_data_;
   };
 
-  static NetworkResourcesData* Create(size_t total_buffer_size,
-                                      size_t resource_buffer_size) {
-    return MakeGarbageCollected<NetworkResourcesData>(total_buffer_size,
-                                                      resource_buffer_size);
-  }
-
   NetworkResourcesData(size_t total_buffer_size, size_t resource_buffer_size);
   ~NetworkResourcesData();