Commit 10cddf87 authored by zhaoyangli's avatar zhaoyangli Committed by Commit Bot

Change location of ensureAppLaunchedWithFeatures call for test case.

Moved ensureAppLaunchedWithFeatures from -setUp to overriding
launchAppForTestMethod to eliminate unnecessary relaunches. CQ bot run
results show significant improvement without the relaunches.

BUG: 1009017, 1010463

Change-Id: I650304daaa9e4271310e180635a8fb6ff865f717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854786Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706521}
parent 84a325cf
...@@ -89,13 +89,16 @@ id<GREYMatcher> CardNumberIconView(NSString* icon_type) { ...@@ -89,13 +89,16 @@ id<GREYMatcher> CardNumberIconView(NSString* icon_type) {
@implementation AutofillAddCreditCardTestCase @implementation AutofillAddCreditCardTestCase
- (void)setUp { - (void)launchAppForTestMethod {
[super setUp];
[[AppLaunchManager sharedManager] [[AppLaunchManager sharedManager]
ensureAppLaunchedWithFeaturesEnabled:{kSettingsAddPaymentMethod, ensureAppLaunchedWithFeaturesEnabled:{kSettingsAddPaymentMethod,
kCreditCardScanner} kCreditCardScanner}
disabled:{} disabled:{}
forceRestart:NO]; forceRestart:NO];
}
- (void)setUp {
[super setUp];
GREYAssertTrue([ChromeEarlGrey isSettingsAddPaymentMethodEnabled], GREYAssertTrue([ChromeEarlGrey isSettingsAddPaymentMethodEnabled],
@"SettingsAddPaymentMethod should be enabled"); @"SettingsAddPaymentMethod should be enabled");
GREYAssertTrue([ChromeEarlGrey isCreditCardScannerEnabled], GREYAssertTrue([ChromeEarlGrey isCreditCardScannerEnabled],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment