Commit 111688c1 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Use std::string::operator= instead of assign() in print_settings.cc.

Change-Id: I3ba220a79a2094ea3bb9c338215c8a14c363ecef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142717
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: default avatarDaniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758032}
parent 702e6d4d
...@@ -58,7 +58,7 @@ void GetColorModelForMode(int color_mode, ...@@ -58,7 +58,7 @@ void GetColorModelForMode(int color_mode,
constexpr char kCUPSXeroxXRXColor[] = "cups-XRXColor"; constexpr char kCUPSXeroxXRXColor[] = "cups-XRXColor";
#endif // defined(OS_MACOSX) #endif // defined(OS_MACOSX)
color_setting_name->assign(kCUPSColorModel); *color_setting_name = kCUPSColorModel;
base::Optional<ColorModel> color_model = ColorModeToColorModel(color_mode); base::Optional<ColorModel> color_model = ColorModeToColorModel(color_mode);
if (!color_model.has_value()) { if (!color_model.has_value()) {
...@@ -68,116 +68,116 @@ void GetColorModelForMode(int color_mode, ...@@ -68,116 +68,116 @@ void GetColorModelForMode(int color_mode,
switch (color_model.value()) { switch (color_model.value()) {
case UNKNOWN_COLOR_MODEL: case UNKNOWN_COLOR_MODEL:
color_value->assign(kGrayscale); *color_value = kGrayscale;
break; break;
case GRAY: case GRAY:
color_value->assign(kGray); *color_value = kGray;
break; break;
case COLOR: case COLOR:
color_value->assign(kColor); *color_value = kColor;
break; break;
case CMYK: case CMYK:
color_value->assign(kCMYK); *color_value = kCMYK;
break; break;
case CMY: case CMY:
color_value->assign(kCMY); *color_value = kCMY;
break; break;
case KCMY: case KCMY:
color_value->assign(kKCMY); *color_value = kKCMY;
break; break;
case CMY_K: case CMY_K:
color_value->assign(kCMY_K); *color_value = kCMY_K;
break; break;
case BLACK: case BLACK:
color_value->assign(kBlack); *color_value = kBlack;
break; break;
case GRAYSCALE: case GRAYSCALE:
color_value->assign(kGrayscale); *color_value = kGrayscale;
break; break;
case RGB: case RGB:
color_value->assign(kRGB); *color_value = kRGB;
break; break;
case RGB16: case RGB16:
color_value->assign(kRGB16); *color_value = kRGB16;
break; break;
case RGBA: case RGBA:
color_value->assign(kRGBA); *color_value = kRGBA;
break; break;
case COLORMODE_COLOR: case COLORMODE_COLOR:
color_setting_name->assign(kCUPSColorMode); *color_setting_name = kCUPSColorMode;
color_value->assign(kColor); *color_value = kColor;
break; break;
case COLORMODE_MONOCHROME: case COLORMODE_MONOCHROME:
color_setting_name->assign(kCUPSColorMode); *color_setting_name = kCUPSColorMode;
color_value->assign(kMonochrome); *color_value = kMonochrome;
break; break;
case HP_COLOR_COLOR: case HP_COLOR_COLOR:
color_setting_name->assign(kColor); *color_setting_name = kColor;
color_value->assign(kColor); *color_value = kColor;
break; break;
case HP_COLOR_BLACK: case HP_COLOR_BLACK:
color_setting_name->assign(kColor); *color_setting_name = kColor;
color_value->assign(kBlack); *color_value = kBlack;
break; break;
case PRINTOUTMODE_NORMAL: case PRINTOUTMODE_NORMAL:
color_setting_name->assign(kCUPSPrintoutMode); *color_setting_name = kCUPSPrintoutMode;
color_value->assign(kNormal); *color_value = kNormal;
break; break;
case PRINTOUTMODE_NORMAL_GRAY: case PRINTOUTMODE_NORMAL_GRAY:
color_setting_name->assign(kCUPSPrintoutMode); *color_setting_name = kCUPSPrintoutMode;
color_value->assign(kNormalGray); *color_value = kNormalGray;
break; break;
case PROCESSCOLORMODEL_CMYK: case PROCESSCOLORMODEL_CMYK:
color_setting_name->assign(kCUPSProcessColorModel); *color_setting_name = kCUPSProcessColorModel;
color_value->assign(kCMYK); *color_value = kCMYK;
break; break;
case PROCESSCOLORMODEL_GREYSCALE: case PROCESSCOLORMODEL_GREYSCALE:
color_setting_name->assign(kCUPSProcessColorModel); *color_setting_name = kCUPSProcessColorModel;
color_value->assign(kGreyscale); *color_value = kGreyscale;
break; break;
case PROCESSCOLORMODEL_RGB: case PROCESSCOLORMODEL_RGB:
color_setting_name->assign(kCUPSProcessColorModel); *color_setting_name = kCUPSProcessColorModel;
color_value->assign(kRGB); *color_value = kRGB;
break; break;
case BROTHER_CUPS_COLOR: case BROTHER_CUPS_COLOR:
color_setting_name->assign(kCUPSBrotherMonoColor); *color_setting_name = kCUPSBrotherMonoColor;
color_value->assign(kFullColor); *color_value = kFullColor;
break; break;
case BROTHER_CUPS_MONO: case BROTHER_CUPS_MONO:
color_setting_name->assign(kCUPSBrotherMonoColor); *color_setting_name = kCUPSBrotherMonoColor;
color_value->assign(kMono); *color_value = kMono;
break; break;
case BROTHER_BRSCRIPT3_COLOR: case BROTHER_BRSCRIPT3_COLOR:
color_setting_name->assign(kCUPSBrotherPrintQuality); *color_setting_name = kCUPSBrotherPrintQuality;
color_value->assign(kColor); *color_value = kColor;
break; break;
case BROTHER_BRSCRIPT3_BLACK: case BROTHER_BRSCRIPT3_BLACK:
color_setting_name->assign(kCUPSBrotherPrintQuality); *color_setting_name = kCUPSBrotherPrintQuality;
color_value->assign(kBlack); *color_value = kBlack;
break; break;
case EPSON_INK_COLOR: case EPSON_INK_COLOR:
color_setting_name->assign(kCUPSInk); *color_setting_name = kCUPSInk;
color_value->assign(kColor); *color_value = kColor;
break; break;
case EPSON_INK_MONO: case EPSON_INK_MONO:
color_setting_name->assign(kCUPSInk); *color_setting_name = kCUPSInk;
color_value->assign(kMono); *color_value = kMono;
break; break;
case SHARP_ARCMODE_CMCOLOR: case SHARP_ARCMODE_CMCOLOR:
color_setting_name->assign(kCUPSSharpARCMode); *color_setting_name = kCUPSSharpARCMode;
color_value->assign(kSharpCMColor); *color_value = kSharpCMColor;
break; break;
case SHARP_ARCMODE_CMBW: case SHARP_ARCMODE_CMBW:
color_setting_name->assign(kCUPSSharpARCMode); *color_setting_name = kCUPSSharpARCMode;
color_value->assign(kSharpCMBW); *color_value = kSharpCMBW;
break; break;
case XEROX_XRXCOLOR_AUTOMATIC: case XEROX_XRXCOLOR_AUTOMATIC:
color_setting_name->assign(kCUPSXeroxXRXColor); *color_setting_name = kCUPSXeroxXRXColor;
color_value->assign(kXeroxAutomatic); *color_value = kXeroxAutomatic;
break; break;
case XEROX_XRXCOLOR_BW: case XEROX_XRXCOLOR_BW:
color_setting_name->assign(kCUPSXeroxXRXColor); *color_setting_name = kCUPSXeroxXRXColor;
color_value->assign(kXeroxBW); *color_value = kXeroxBW;
break; break;
} }
// The default case is excluded from the above switch statement to ensure that // The default case is excluded from the above switch statement to ensure that
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment