Commit 11175107 authored by Leonard Grey's avatar Leonard Grey Committed by Commit Bot

Revert "Don't try to update window title on non-titled browsers"

This reverts commit 5e0ca406.

Reason for revert: https://crbug.com/837825

Original change's description:
> Don't try to update window title on non-titled browsers
> 
> This causes two unnecessary layouts of BrowserView, each of which causes
> three layouts of ToolbarView, each of which causes a whole bunch of
> things to happen.
> 
> ChromeOS is excluded since even on a tabbed browser, it relies on
> the title to be updated to set the accessibility title.
> 
> Bug: 835983
> Change-Id: I4a62579f8fae394a6c11eb7c8632da176452b00d
> Reviewed-on: https://chromium-review.googlesource.com/1024828
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554040}

TBR=ellyjones@chromium.org,lgrey@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 835983
Change-Id: I238505c04e1943ce45d69e46c18f633c376acc02
Reviewed-on: https://chromium-review.googlesource.com/1034762Reviewed-by: default avatarLeonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554743}
parent 9df38cd4
......@@ -682,14 +682,7 @@ StatusBubble* BrowserView::GetStatusBubble() {
}
void BrowserView::UpdateTitleBar() {
#if !defined(OS_CHROMEOS)
if (ShouldShowWindowTitle())
frame_->UpdateWindowTitle();
#else
// ChromeOS needs this to be called even on a tabbed browser to
// set the accessible title.
frame_->UpdateWindowTitle();
#endif
if (ShouldShowWindowIcon() && !loading_animation_timer_.IsRunning())
frame_->UpdateWindowIcon();
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment