Commit 1138d602 authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

[ThreadPool] Fix docs to match new API

R=etiennep@chromium.org

Bug: 1026641
Change-Id: I68c6e40f080ac5808cd9c67e227695ca921e1691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026714
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: default avatarEtienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736281}
parent 7ca178b8
...@@ -654,8 +654,7 @@ void WorkerTask(base::JobDelegate* job_delegate) { ...@@ -654,8 +654,7 @@ void WorkerTask(base::JobDelegate* job_delegate) {
// Returns the latest thread-safe number of incomplete work items. // Returns the latest thread-safe number of incomplete work items.
void NumIncompleteWorkItems(); void NumIncompleteWorkItems();
base::PostJob(FROM_HERE, base::PostJob(FROM_HERE, {},
{base::ThreadPool()},
base::BindRepeating(&WorkerTask), base::BindRepeating(&WorkerTask),
base::BindRepeating(&NumIncompleteWorkItems)); base::BindRepeating(&NumIncompleteWorkItems));
``` ```
......
...@@ -106,9 +106,8 @@ class FooService { ...@@ -106,9 +106,8 @@ class FooService {
public: public:
FooService() FooService()
: backend_task_runner_( : backend_task_runner_(
base::CreateSequencedTaskRunnerWithTraits( base::ThreadPool::CreateSequencedTaskRunner(
base::MayBlock(), base::ThreadPool(), {base::MayBlock(), base::TaskPriority::BEST_EFFORT})),
base::TaskPriority::BEST_EFFORT))),
backend_(new FooBackend, backend_(new FooBackend,
base::OnTaskRunnerDeleter(backend_task_runner_)) {} base::OnTaskRunnerDeleter(backend_task_runner_)) {}
...@@ -117,7 +116,7 @@ class FooService { ...@@ -117,7 +116,7 @@ class FooService {
DCHECK(owning_sequence_->RunsTasksInCurrentSequence()); DCHECK(owning_sequence_->RunsTasksInCurrentSequence());
backend_task_runner_->PostTaskAndReply( backend_task_runner_->PostTaskAndReply(
base::BindOnce(&FooBackend::Flush, Unretained(backend_.get()), base::BindOnce(&FooBackend::Flush, Unretained(backend_.get()),
std::move(on_done)); std::move(on_done)));
} }
private: private:
...@@ -254,12 +253,12 @@ TEST(FooTest, TimeoutExceeded) ...@@ -254,12 +253,12 @@ TEST(FooTest, TimeoutExceeded)
base::test::TaskEnvironment::TimeSource::MOCK_TIME}; base::test::TaskEnvironment::TimeSource::MOCK_TIME};
base::WaitableEvent event; base::WaitableEvent event;
base::RunLoop run_loop; base::RunLoop run_loop;
base::PostTaskAndReply( base::ThreadPool::PostTaskAndReply(
FROM_HERE, {base::ThreadPool(), base::MayBlock()}, FROM_HERE, {base::MayBlock()},
base::BindOnce(&BlocksOnEvent, base::Unretained(&event)), base::BindOnce(&BlocksOnEvent, base::Unretained(&event)),
run_loop.QuitClosure()); run_loop.QuitClosure());
base::PostDelayedTask( base::ThreadPool::PostDelayedTask(
FROM_HERE, {base::ThreadPool()}, FROM_HERE, {},
base::BindOnce(&WaitableEvent::Signal, base::Unretained(&event)), base::BindOnce(&WaitableEvent::Signal, base::Unretained(&event)),
kTimeout); kTimeout);
// Can't use task_environment.FastForwardBy() since BlocksOnEvent blocks // Can't use task_environment.FastForwardBy() since BlocksOnEvent blocks
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment