Commit 11459efc authored by tanay.c's avatar tanay.c Committed by Commit bot

Remove [TreatNullAs=NullString] from attributes on RTCIceCandidate

Current Behaviour:
Chrome :
RTCIceCandidate.candidate = null => ""
RTCIceCandidate.sdpMid  = null => ""

Firefox :
RTCIceCandidate.candidate = null => "null"
RTCIceCandidate.sdpMid  = null => "null"

After the change:
Chrome:
RTCIceCandidate.candidate = null => "null"
RTCIceCandidate.sdpMid  = null => "null"

This aligns with the behavior on Firefox nightly

BUG=497307

Review URL: https://codereview.chromium.org/1431793002

Cr-Commit-Position: refs/heads/master@{#361087}
parent a0a01db6
......@@ -20,6 +20,8 @@ PASS new RTCIceCandidate({candidate:"x"}); did not throw exception.
PASS candidate.candidate is "bar"
PASS candidate.sdpMid is "foo"
PASS candidate.sdpMLineIndex is 0
PASS candidate.candidate is "null"
PASS candidate.sdpMid is "null"
PASS successfullyParsed is true
TEST COMPLETE
......
......@@ -38,6 +38,10 @@ shouldBeEqualToString('candidate.candidate', 'bar');
shouldBeEqualToString('candidate.sdpMid', 'foo');
shouldBe('candidate.sdpMLineIndex', '0');
candidate.candidate = null;
candidate.sdpMid = null;
shouldBeEqualToString('candidate.candidate', 'null');
shouldBeEqualToString('candidate.sdpMid', 'null');
window.successfullyParsed = true;
</script>
......
......@@ -33,8 +33,8 @@
Constructor(RTCIceCandidateInit candidateInitDict),
RaisesException=Constructor
] interface RTCIceCandidate {
[TreatNullAs=NullString] attribute DOMString candidate;
[TreatNullAs=NullString] attribute DOMString sdpMid;
attribute DOMString candidate;
attribute DOMString sdpMid;
attribute unsigned short sdpMLineIndex;
serializer = {attribute};
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment