[Passwords] Migrate Password Manager Bubble to use SetTitle() API

All subclasses PasswordBubbleControllerBase return a fixed
title (i.e. the title doesn't change during the life time
of the controller)
except SaveUpdateBubbleController.

Therefore, for all other controllers, it's safe to set the title
only once.

For SaveUpdateBubbleController(), GetTitle() has been made public
such that the view can query it when the title changes.

Bug: 1044038,1090740
Change-Id: I47799ad4b2b55568bfbae3ef9b884c1b25085d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231038
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775747}

chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc

@@ -233,6 +233,10 @@ bool SaveUpdateBubbleController::RevealPasswords() {
   return reveal_immediately;
 }
 
+base::string16 SaveUpdateBubbleController::GetTitle() const {
+  return title_;
+}
+
 void SaveUpdateBubbleController::ReportInteractions() {
   if (state_ == password_manager::ui::CHROME_SIGN_IN_PROMO_STATE)
     return;
@@ -278,7 +282,3 @@ void SaveUpdateBubbleController::ReportInteractions() {
   if (metrics_recorder_)
     metrics_recorder_->RecordUIDismissalReason(dismissal_reason_);
 }
-
-base::string16 SaveUpdateBubbleController::GetTitle() const {
-  return title_;
-}

chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.h

@@ -61,6 +61,9 @@ class SaveUpdateBubbleController : public PasswordBubbleControllerBase {
   // re-authentication is successful.
   bool RevealPasswords();
 
+  // PasswordBubbleControllerBase methods:
+  base::string16 GetTitle() const override;
+
   password_manager::ui::State state() const { return state_; }
 
   const autofill::PasswordForm& pending_password() const {
@@ -87,7 +90,6 @@ class SaveUpdateBubbleController : public PasswordBubbleControllerBase {
 
  private:
   // PasswordBubbleControllerBase methods:
-  base::string16 GetTitle() const override;
   void ReportInteractions() override;
 
   // Origin of the page from where this bubble was triggered.

chrome/browser/ui/views/passwords/password_bubble_view_base.cc

@@ -119,18 +119,6 @@ const content::WebContents* PasswordBubbleViewBase::GetWebContents() const {
   return controller->GetWebContents();
 }
 
-base::string16 PasswordBubbleViewBase::GetWindowTitle() const {
-  const PasswordBubbleControllerBase* controller = GetController();
-  DCHECK(controller);
-  return controller->GetTitle();
-}
-
-bool PasswordBubbleViewBase::ShouldShowWindowTitle() const {
-  const PasswordBubbleControllerBase* controller = GetController();
-  DCHECK(controller);
-  return !controller->GetTitle().empty();
-}
-
 PasswordBubbleViewBase::PasswordBubbleViewBase(
     content::WebContents* web_contents,
     views::View* anchor_view,
@@ -151,6 +139,14 @@ PasswordBubbleViewBase::~PasswordBubbleViewBase() {
     g_manage_passwords_bubble_ = nullptr;
 }
 
+void PasswordBubbleViewBase::Init() {
+  LocationBarBubbleDelegateView::Init();
+  const PasswordBubbleControllerBase* controller = GetController();
+  DCHECK(controller);
+  SetTitle(controller->GetTitle());
+  SetShowTitle(!controller->GetTitle().empty());
+}
+
 void PasswordBubbleViewBase::OnWidgetClosing(views::Widget* widget) {
   LocationBarBubbleDelegateView::OnWidgetClosing(widget);
   if (widget != GetWidget())

chrome/browser/ui/views/passwords/password_bubble_view_base.h

@@ -57,10 +57,6 @@ class PasswordBubbleViewBase : public LocationBarBubbleDelegateView {
   virtual PasswordBubbleControllerBase* GetController() = 0;
   virtual const PasswordBubbleControllerBase* GetController() const = 0;
 
-  // LocationBarBubbleDelegateView:
-  base::string16 GetWindowTitle() const override;
-  bool ShouldShowWindowTitle() const override;
-
  protected:
   // The |easily_dismissable| flag indicates if the bubble should close upon
   // a click in the content area of the browser.
@@ -71,6 +67,9 @@ class PasswordBubbleViewBase : public LocationBarBubbleDelegateView {
   ~PasswordBubbleViewBase() override;
 
  private:
+  // views::BubbleDialogDelegateView:
+  void Init() override;
+
   // WidgetObserver:
   void OnWidgetClosing(views::Widget* widget) override;
 

chrome/browser/ui/views/passwords/password_save_update_view.cc

@@ -466,7 +466,7 @@ void PasswordSaveUpdateView::ReplaceWithPromo() {
     NOTREACHED();
   }
   GetWidget()->UpdateWindowIcon();
-  GetWidget()->UpdateWindowTitle();
+  SetTitle(controller_.GetTitle());
   UpdateDialogButtons();
   DialogModelChanged();