Commit 11636f95 authored by Mounir Lamouri's avatar Mounir Lamouri Committed by Chromium LUCI CQ

Kaleidoscope: add "welcome" first run experience step.

Bug: b/170751292
Change-Id: I510d25920515eb568deb3f6316ae4c626950b80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552410
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarBecca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832220}
parent 309f3236
......@@ -17,6 +17,8 @@ KaleidoscopeMetricsRecorder::FirstRunProgress MojoStepToMetricsStep(
return KaleidoscopeMetricsRecorder::FirstRunProgress::kProviderSelection;
case media::mojom::KaleidoscopeFirstRunExperienceStep::kMediaFeedsConsent:
return KaleidoscopeMetricsRecorder::FirstRunProgress::kMediaFeedsConsent;
case media::mojom::KaleidoscopeFirstRunExperienceStep::kWelcome:
return KaleidoscopeMetricsRecorder::FirstRunProgress::kWelcome;
}
NOTREACHED();
}
......
......@@ -18,7 +18,8 @@ class KaleidoscopeMetricsRecorder {
kCompleted = 0,
kProviderSelection = 1,
kMediaFeedsConsent = 2,
kMaxValue = kMediaFeedsConsent,
kWelcome = 3,
kMaxValue = kWelcome,
};
KaleidoscopeMetricsRecorder();
......
......@@ -49,6 +49,9 @@ TEST_F(KaleidoscopeMetricsRecorderTest, OnExitRecordsCurrentStep) {
recorder().OnFirstRunExperienceStepChanged(
media::mojom::KaleidoscopeFirstRunExperienceStep::kProviderSelection);
ExpectFirstRunProgressTotalCount(0);
recorder().OnFirstRunExperienceStepChanged(
media::mojom::KaleidoscopeFirstRunExperienceStep::kWelcome);
ExpectFirstRunProgressTotalCount(0);
recorder().OnFirstRunExperienceStepChanged(
media::mojom::KaleidoscopeFirstRunExperienceStep::kMediaFeedsConsent);
ExpectFirstRunProgressTotalCount(0);
......
......@@ -44,6 +44,7 @@ enum KaleidoscopeFirstRunExperienceStep {
kCompleted,
kProviderSelection,
kMediaFeedsConsent,
kWelcome,
};
// Provides data for the kaleidoscope page.
......
......@@ -39759,6 +39759,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.-->
<int value="0" label="Completed"/>
<int value="1" label="Provider Selection"/>
<int value="2" label="Media Feeds Consent"/>
<int value="3" label="Welcome Screen"/>
</enum>
<enum name="KaleidoscopeNavigation">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment