Commit 1194dfbf authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Re-enable Telemetry minidump tests

Re-enables the Telemetry minidump tests on most platforms. They were
disabled due to flakiness, but further investigation shows that the
flake rate was relatively low, and some flakes were caused by unrelated
issues, e.g. platform-wide issues.

Bug: 1084931
Change-Id: I31fab19af04faea49826dc827a45817da3de9397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318505
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarAchuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791977}
parent b5b1875a
...@@ -34,8 +34,12 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase): ...@@ -34,8 +34,12 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase):
# Minidump symbolization doesn't work in ChromeOS local mode if the rootfs is # Minidump symbolization doesn't work in ChromeOS local mode if the rootfs is
# still read-only, so skip the test in that case. # still read-only, so skip the test in that case.
# TODO(crbug.com/1038043): Test is failing on chromeos-betty-chrome. # TODO(crbug.com/1038043): Test is failing on chromeos-betty-chrome.
# Flaky on all platforms: https://crbug.com/1084931 @decorators.Disabled(
@decorators.Disabled('all') 'chromeos-local',
'chromeos-board-betty',
'chromeos-board-betty-pi-arc',
'win' # https://crbug.com/1084931
)
def testSymbolizeMinidump(self): def testSymbolizeMinidump(self):
# Wait for the browser to restart fully before crashing # Wait for the browser to restart fully before crashing
self._LoadPageThenWait('var sam = "car";', 'sam') self._LoadPageThenWait('var sam = "car";', 'sam')
...@@ -78,8 +82,12 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase): ...@@ -78,8 +82,12 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase):
# Minidump symbolization doesn't work in ChromeOS local mode if the rootfs is # Minidump symbolization doesn't work in ChromeOS local mode if the rootfs is
# still read-only, so skip the test in that case. # still read-only, so skip the test in that case.
# TODO(crbug.com/1038043): Test is failing on chromeos-betty-chrome. # TODO(crbug.com/1038043): Test is failing on chromeos-betty-chrome.
# TODO(crbug.com/1084931): Test is failing on win, mac, others? @decorators.Disabled(
@decorators.Disabled('all') 'chromeos-local',
'chromeos-board-betty',
'chromeos-board-betty-pi-arc',
'win' # https://crbug.com/1084931
)
def testMultipleCrashMinidumps(self): def testMultipleCrashMinidumps(self):
# Wait for the browser to restart fully before crashing # Wait for the browser to restart fully before crashing
self._LoadPageThenWait('var cat = "dog";', 'cat') self._LoadPageThenWait('var cat = "dog";', 'cat')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment