Commit 1196a462 authored by Peter Beverloo's avatar Peter Beverloo Committed by Commit Bot

Pass expected exception type to fix a notification test

Passing `null` no longer is allowed by testharness.js, which caused this
test to start failing. Easy fix :)

Bug: 711529
Change-Id: I6667c6fc86bafab0dae0607b44f80aed40e192bd
Reviewed-on: https://chromium-review.googlesource.com/802557
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: default avatarAnita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521332}
parent bb842778
......@@ -1862,13 +1862,11 @@ crbug.com/704259 external/wpt/content-security-policy/reporting/reporting-api-re
crbug.com/704259 external/wpt/content-security-policy/reporting/reporting-api-sends-reports-on-violation.https.sub.html [ Skip ]
# These HTTP tests that started failing after a web-platform-tests import.
crbug.com/711529 http/tests/notifications/serviceworker-notification-event.html [ Timeout ]
crbug.com/711529 http/tests/origin_trials/sample-api-workers.html [ Crash Timeout ]
crbug.com/711529 http/tests/permissions/test-api-surface.html [ Timeout ]
crbug.com/711529 http/tests/permissions/test-query.html [ Timeout ]
crbug.com/711529 http/tests/security/cross-origin-createImageBitmap-structured-clone.html [ Timeout ]
crbug.com/711529 http/tests/workers/shared-worker-performance-timeline.html [ Timeout ]
crbug.com/711529 virtual/mojo-notifications/http/tests/notifications/serviceworker-notification-event.html [ Timeout ]
crbug.com/713587 external/wpt/css/css-ui/caret-color-006.html [ Skip ]
......
......@@ -17,9 +17,9 @@ function runTest(notification) {
try {
assert_true('NotificationEvent' in self);
assert_throws(null, () => new NotificationEvent('NotificationEvent'));
assert_throws(null, () => new NotificationEvent('NotificationEvent', {}));
assert_throws(null, () => new NotificationEvent('NotificationEvent', { notification: null }));
assert_throws(new TypeError(), () => new NotificationEvent('NotificationEvent'));
assert_throws(new TypeError(), () => new NotificationEvent('NotificationEvent', {}));
assert_throws(new TypeError(), () => new NotificationEvent('NotificationEvent', { notification: null }));
const event = new NotificationEvent('NotificationEvent', { notification });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment