android: list pending uploads before done uploads

The upload list is capped at 50 crashes. Previously, the already
completed uploads were listed before the pending uploads. This
patch places the pending uploads first so that it is possible for the
user to see them and manually* trigger an upload.

*The "send now" button does not actually send the report now. It
schedules the dump for upload at a later time of the Job Scheduler's
choosing.

Bug: 1023836
Change-Id: Ided52abc451f4ac167dc9eb0db93d4ea32bdc090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917689Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715385}

chrome/browser/crash_upload_list/crash_upload_list_android.cc

@@ -58,10 +58,14 @@ bool CrashUploadListAndroid::DidBrowserCrashRecently() {
 }
 
 std::vector<UploadList::UploadInfo> CrashUploadListAndroid::LoadUploadList() {
-  // First load the list of successfully uploaded logs.
-  std::vector<UploadInfo> uploads = TextLogUploadList::LoadUploadList();
-  // Then load the unsuccessful uploads.
+  std::vector<UploadInfo> uploads;
   LoadUnsuccessfulUploadList(&uploads);
+
+  std::vector<UploadInfo> complete_uploads =
+      TextLogUploadList::LoadUploadList();
+  for (auto info : complete_uploads) {
+    uploads.push_back(info);
+  }
   return uploads;
 }