[IPC] Remove ChromeExtensionMsgStart

This value has no meaningful usage in the codebase. Its removal has
ripple effects:
- chrome_extension_messages.h is no longer needed and is removed
- cast_extension_messages.{cc, h} are no longer needed and are removed

This CL is part of the ongoing effort to eliminate the legacy IPC
system.

Change-Id: Icc8a679d0da0f58df99f9692ba2be5ebee42966b
Bug: 1007300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834091
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703241}

chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc

@@ -11,7 +11,6 @@
 #include "chrome/browser/chromeos/arc/accessibility/accessibility_window_info_data_wrapper.h"
 #include "chrome/browser/chromeos/arc/accessibility/arc_accessibility_util.h"
 #include "chrome/browser/ui/aura/accessibility/automation_manager_aura.h"
-#include "chrome/common/extensions/chrome_extension_messages.h"
 #include "extensions/browser/api/automation_internal/automation_event_router.h"
 #include "extensions/common/extension_messages.h"
 #include "ui/accessibility/platform/ax_android_constants.h"

chrome/browser/extensions/api/automation/automation_apitest.cc

@@ -16,7 +16,6 @@
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
-#include "chrome/common/extensions/chrome_extension_messages.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/prefs/pref_service.h"

chrome/browser/extensions/api/automation_internal/chrome_automation_internal_api_delegate.cc

@@ -13,7 +13,6 @@
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/common/extensions/chrome_extension_messages.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/common/api/automation.h"
 #include "extensions/common/api/automation_internal.h"

chrome/browser/extensions/chrome_extension_web_contents_observer.cc

@@ -11,7 +11,6 @@
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
-#include "chrome/common/extensions/chrome_extension_messages.h"
 #include "chrome/common/url_constants.h"
 #include "components/rappor/rappor_service_impl.h"
 #include "content/public/browser/browser_context.h"

chrome/browser/renderer_host/chrome_extension_message_filter.cc

@@ -22,7 +22,6 @@
 #include "chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
-#include "chrome/common/extensions/chrome_extension_messages.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "extensions/browser/extension_registry.h"
@@ -39,7 +38,7 @@ using content::BrowserThread;
 namespace {
 
 const uint32_t kExtensionFilteredMessageClasses[] = {
-    ChromeExtensionMsgStart, ExtensionMsgStart,
+    ExtensionMsgStart,
 };
 
 // Logs an action to the extension activity log for the specified profile.

chrome/browser/ui/apps/chrome_app_delegate.cc

@@ -29,7 +29,6 @@
 #include "chrome/browser/ui/color_chooser.h"
 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
 #include "chrome/browser/ui/web_contents_sizer.h"
-#include "chrome/common/extensions/chrome_extension_messages.h"
 #include "components/keep_alive_registry/keep_alive_types.h"
 #include "components/keep_alive_registry/scoped_keep_alive.h"
 #include "components/zoom/zoom_controller.h"

chrome/common/BUILD.gn

@@ -314,7 +314,6 @@ static_library("common") {
       "extensions/api/system_indicator/system_indicator_handler.h",
       "extensions/api/url_handlers/url_handlers_parser.cc",
       "extensions/api/url_handlers/url_handlers_parser.h",
-      "extensions/chrome_extension_messages.h",
       "extensions/chrome_extensions_api_provider.cc",
       "extensions/chrome_extensions_api_provider.h",
       "extensions/chrome_extensions_client.cc",

chrome/common/common_message_generator.h

@@ -35,11 +35,6 @@
 #ifndef CHROME_COMMON_CAST_MESSAGES_H_
 #error "Failed to include header chrome/common/cast_messages.h"
 #endif
-#undef CHROME_COMMON_EXTENSIONS_CHROME_EXTENSION_MESSAGES_H_
-#include "chrome/common/extensions/chrome_extension_messages.h"
-#ifndef CHROME_COMMON_EXTENSIONS_CHROME_EXTENSION_MESSAGES_H_
-#error "Failed to include chrome/common/extensions/chrome_extension_messages.h"
-#endif
 #endif
 
 #if BUILDFLAG(ENABLE_PRINTING)

chrome/common/extensions/chrome_extension_messages.h

-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_COMMON_EXTENSIONS_CHROME_EXTENSION_MESSAGES_H_
-#define CHROME_COMMON_EXTENSIONS_CHROME_EXTENSION_MESSAGES_H_
-
-// Chrome-specific IPC messages for extensions.
-// Extension-related messages that aren't specific to Chrome live in
-// extensions/common/extension_messages.h.
-
-#include <stdint.h>
-
-#include <string>
-
-#include "base/strings/string16.h"
-#include "base/values.h"
-#include "extensions/common/api/automation_internal.h"
-#include "extensions/common/stack_frame.h"
-#include "ipc/ipc_message_macros.h"
-#include "ui/accessibility/ax_enums.mojom.h"
-#include "ui/accessibility/ax_event.h"
-#include "ui/accessibility/ax_node_data.h"
-#include "ui/accessibility/ax_relative_bounds.h"
-#include "ui/accessibility/ax_tree_data.h"
-#include "ui/accessibility/ax_tree_update.h"
-#include "ui/gfx/transform.h"
-#include "url/gurl.h"
-
-#define IPC_MESSAGE_START ChromeExtensionMsgStart
-
-// Messages sent from the browser to the renderer.
-
-#endif  // CHROME_COMMON_EXTENSIONS_CHROME_EXTENSION_MESSAGES_H_

chromecast/browser/cast_extension_message_filter.cc

@@ -14,7 +14,6 @@
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task/post_task.h"
-#include "chromecast/common/extensions_api/cast_extension_messages.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
@@ -32,7 +31,7 @@ using content::BrowserThread;
 namespace {
 
 const uint32_t kExtensionFilteredMessageClasses[] = {
-    ChromeExtensionMsgStart, ExtensionMsgStart,
+    ExtensionMsgStart,
 };
 
 }  // namespace

chromecast/common/BUILD.gn

@@ -51,8 +51,6 @@ cast_source_set("common") {
       "cast_redirect_manifest_handler.h",
       "extensions_api/cast_api_permissions.cc",
       "extensions_api/cast_api_permissions.h",
-      "extensions_api/cast_extension_messages.cc",
-      "extensions_api/cast_extension_messages.h",
     ]
 
     deps += [

chromecast/common/extensions_api/cast_extension_messages.cc

-// Copyright (c) 2018 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-//
-
-// Get basic type definitions.
-#define IPC_MESSAGE_IMPL
-#undef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#include "chromecast/common/extensions_api/cast_extension_messages.h"
-#include "content/public/common/common_param_traits.h"
-#ifndef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#error "Failed to include header chromecast/common/extensions_api/"
-"chrome_extension_messages.h"
-#endif
-
-// Generate constructors.
-#include "ipc/struct_constructor_macros.h"
-#undef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#include "chromecast/common/extensions_api/cast_extension_messages.h"
-#include "content/public/common/common_param_traits.h"
-#ifndef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#error "Failed to include header chromecast/common/extensions_api/"
-    "chrome_extension_messages.h"
-#endif
-
-// Generate param traits write methods.
-#include "ipc/param_traits_write_macros.h"
-    namespace IPC {
-#undef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#include "chromecast/common/extensions_api/cast_extension_messages.h"
-#include "content/public/common/common_param_traits.h"
-#ifndef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#error "Failed to include header chromecast/common/extensions_api/"
-  "chrome_extension_messages.h"
-#endif
-}  // namespace IPC
-
-// Generate param traits read methods.
-#include "ipc/param_traits_read_macros.h"
-namespace IPC {
-#undef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#include "chromecast/common/extensions_api/cast_extension_messages.h"
-#include "content/public/common/common_param_traits.h"
-#ifndef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#error "Failed to include header chromecast/common/extensions_api/"
-"chrome_extension_messages.h"
-#endif
-}  // namespace IPC
-
-// Generate param traits log methods.
-#include "ipc/param_traits_log_macros.h"
-namespace IPC {
-#undef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#include "chromecast/common/extensions_api/cast_extension_messages.h"
-#include "content/public/common/common_param_traits.h"
-#ifndef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#error "Failed to include header chromecast/common/extensions_api/"
-"chrome_extension_messages.h"
-#endif
-}  // namespace IPC

chromecast/common/extensions_api/cast_extension_messages.h

-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-#define CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_
-
-// Cast-specific IPC messages for extensions.
-// Extension-related messages that aren't specific to Chromecast live in
-// extensions/common/extension_messages.h.
-
-#include <stdint.h>
-
-#include <string>
-
-#include "base/strings/string16.h"
-#include "base/values.h"
-#include "extensions/common/api/automation_internal.h"
-#include "extensions/common/stack_frame.h"
-#include "ipc/ipc_message_macros.h"
-#include "ui/accessibility/ax_enums.mojom.h"
-#include "ui/accessibility/ax_event.h"
-#include "ui/accessibility/ax_node_data.h"
-#include "ui/accessibility/ax_relative_bounds.h"
-#include "ui/accessibility/ax_tree_data.h"
-#include "ui/accessibility/ax_tree_update.h"
-#include "ui/gfx/transform.h"
-#include "url/gurl.h"
-
-#define IPC_MESSAGE_START ChromeExtensionMsgStart
-
-// Messages sent from the browser to the renderer.
-
-#endif  // CHROMECAST_COMMON_EXTENSIONS_API_CAST_EXTENSION_MESSAGES_H_

ipc/ipc_message_start.h

@@ -42,7 +42,6 @@ enum IPCMessageStart {
   NaClHostMsgStart,
   EncryptedMediaMsgStart,
   CastMsgStart,
-  ChromeExtensionMsgStart,
   GinJavaBridgeMsgStart,
   ChromeUtilityPrintingMsgStart,
   OzoneGpuMsgStart,