[MD extensions] View-in-store feature for Details page

This CL adds a View in store link row that links to the extension home
page as well as a link row for the Chrome Web Store page for the extension.

Bug: 794286
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I06a8c078f0659adc3c69e6139133ec9cf6a81d9a
Reviewed-on: https://chromium-review.googlesource.com/826473
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524325}

chrome/browser/extensions/api/developer_private/extension_info_generator.cc

@@ -411,6 +411,13 @@ void ExtensionInfoGenerator::CreateExtensionInfoHelper(
   info->home_page.url = ManifestURL::GetHomepageURL(&extension).spec();
   info->home_page.specified = ManifestURL::SpecifiedHomepageURL(&extension);
 
+  // Developer and web store URLs.
+  // TODO(dschuyler) after MD extensions releases (expected in m64), look into
+  // removing the |home_page.url| and |home_page.specified| above.
+  info->manifest_home_page_url =
+      ManifestURL::GetManifestHomePageURL(&extension).spec();
+  info->web_store_url = ManifestURL::GetWebStoreURL(&extension).spec();
+
   info->id = extension.id();
 
   // Incognito access.

chrome/browser/resources/md_extensions/detail_view.html

@@ -163,7 +163,7 @@
         margin: 0;
       }
 
-      #remove-extension {
+      button[is='cr-link-row'] {
         width: 100%;
       }
 
@@ -364,6 +364,14 @@
           <button class="icon-external" is="paper-icon-button-light"
               aria-labelledby="optionLabel" actionable></button>
         </div>
+        <button class="hr" hidden="[[!data.manifestHomePageUrl.length]]"
+            is="cr-link-row" icon-class="icon-external" id="developerWebsite"
+            label="$i18n{developerWebsite}" on-tap="onDeveloperWebSiteTap_">
+        </button>
+        <button class="hr" hidden="[[!data.webStoreUrl.length]]"
+            is="cr-link-row" icon-class="icon-external" id="viewInStore"
+            label="$i18n{viewInStore}" on-tap="onViewInStoreTap_">
+        </button>
         <div class="section block">
           <div class="section-title">$i18n{itemSource}</div>
           <div id="source" class="section-content">

chrome/browser/resources/md_extensions/detail_view.js

@@ -113,18 +113,6 @@ cr.define('extensions', function() {
       return extensions.computeInspectableViewLabel(view);
     },
 
-    /**
-     * @return {boolean}
-     * @private
-     */
-    shouldShowHomepageButton_: function() {
-      // Note: we ignore |data.homePage.specified| - we use an extension's
-      // webstore entry as a homepage if the extension didn't explicitly specify
-      // a homepage. (|url| can still be unset in the case of unpacked
-      // extensions.)
-      return this.data.homePage.url.length > 0;
-    },
-
     /**
      * @return {boolean}
      * @private
@@ -202,19 +190,28 @@ cr.define('extensions', function() {
     },
 
     /** @private */
-    onIconClick_: function(e) {
-      e.preventDefault();
+    onDeveloperWebSiteTap_: function() {
+      this.delegate.openUrl(this.data.manifestHomePageUrl);
+    },
+
+    /** @private */
+    onViewInStoreTap_: function() {
+      this.delegate.openUrl(this.data.webStoreUrl);
     },
 
     /**
      * @param {!chrome.developerPrivate.DependentExtension} item
+     * @return {string}
      * @private
      */
     computeDependentEntry_: function(item) {
       return loadTimeData.getStringF('itemDependentEntry', item.name, item.id);
     },
 
-    /** @private */
+    /**
+     * @return {string}
+     * @private
+     */
     computeSourceString_: function() {
       return this.data.locationText ||
           extensions.getItemSourceString(extensions.getItemSource(this.data));

chrome/browser/resources/md_extensions/item.js

@@ -44,6 +44,11 @@ cr.define('extensions', function() {
      */
     inspectItemView(id, view) {}
 
+    /**
+     * @param {string} url
+     */
+    openUrl(url) {}
+
     /**
      * @param {string} id
      * @return {!Promise}

chrome/browser/resources/md_extensions/service.js

@@ -174,6 +174,14 @@ cr.define('extensions', function() {
       });
     }
 
+    /**
+     * @param {string} url
+     * @override
+     */
+    openUrl(url) {
+      window.open(url);
+    }
+
     /** @override */
     reloadItem(id) {
       return new Promise(function(resolve, reject) {

chrome/browser/ui/webui/extensions/extensions_ui.cc

@@ -144,6 +144,13 @@ content::WebUIDataSource* CreateMdExtensionsSource(bool in_dev_mode) {
   source->AddLocalizedString("noExtensionsOrApps",
                              IDS_MD_EXTENSIONS_NO_INSTALLED_ITEMS);
   source->AddLocalizedString("noDescription", IDS_MD_EXTENSIONS_NO_DESCRIPTION);
+  // TODO(dschuyler): define "viewInStore" as IDS_MD_EXTENSIONS_VIEW_IN_STORE.
+  source->AddLocalizedString("viewInStore",
+                             IDS_APPLICATION_INFO_WEB_STORE_LINK);
+  // TODO(dschuyler): define "developerWebsite" as
+  // IDS_MD_EXTENSIONS_DEVELOPER_WEBSITE.
+  source->AddLocalizedString("developerWebsite",
+                             IDS_APPLICATION_INFO_HOMEPAGE_LINK);
   source->AddLocalizedString("noSearchResults", IDS_SEARCH_NO_RESULTS);
   source->AddLocalizedString("searchResults", IDS_SEARCH_RESULTS);
   source->AddLocalizedString("dropToInstall",

chrome/common/extensions/api/developer_private.idl

@@ -207,6 +207,7 @@ namespace developerPrivate {
     Location location;
     DOMString? locationText;
     ManifestError[] manifestErrors;
+    DOMString manifestHomePageUrl;
     boolean mustRemainInstalled;
     DOMString name;
     boolean offlineEnabled;
@@ -223,6 +224,7 @@ namespace developerPrivate {
     boolean userMayModify;
     DOMString version;
     ExtensionView[] views;
+    DOMString webStoreUrl;
   };
 
   dictionary ProfileInfo {
@@ -598,7 +600,7 @@ namespace developerPrivate {
     static void openDevTools(OpenDevToolsProperties properties,
                              optional VoidCallback callback);
 
-    // Delete reported extension erors.
+    // Delete reported extension errors.
     // |properties| : The properties specifying the errors to remove.
     static void deleteExtensionErrors(
         DeleteExtensionErrorsProperties properties,

chrome/test/data/webui/extensions/extension_detail_view_test.js

@@ -106,8 +106,19 @@ cr.define('extension_detail_view_tests', function() {
       item.set('data.optionsPage', {openInTab: true, url: optionsUrl});
       expectTrue(testIsVisible('#extensions-options'));
 
-      // TODO(devlin): Add checks for homepage once it's added back to the
-      // mocks.
+      item.set('data.manifestHomePageUrl', 'http://example.com');
+      Polymer.dom.flush();
+      expectTrue(testIsVisible('#developerWebsite'));
+      item.set('data.manifestHomePageUrl', '');
+      Polymer.dom.flush();
+      expectFalse(testIsVisible('#developerWebsite'));
+
+      item.set('data.webStoreUrl', 'http://example.com');
+      Polymer.dom.flush();
+      expectTrue(testIsVisible('#viewInStore'));
+      item.set('data.webStoreUrl', '');
+      Polymer.dom.flush();
+      expectFalse(testIsVisible('#viewInStore'));
 
       expectFalse(testIsVisible('#id-section'));
       expectFalse(testIsVisible('#inspectable-views'));

extensions/common/manifest_url_handlers.cc

@@ -5,6 +5,7 @@
 #include "extensions/common/manifest_url_handlers.h"
 
 #include <memory>
+#include <utility>
 
 #include "base/files/file_util.h"
 #include "base/strings/string_util.h"
@@ -38,6 +39,22 @@ const GURL ManifestURL::GetHomepageURL(const Extension* extension) {
   const GURL& homepage_url = Get(extension, keys::kHomepageURL);
   if (homepage_url.is_valid())
     return homepage_url;
+  return GetWebStoreURL(extension);
+}
+
+// static
+bool ManifestURL::SpecifiedHomepageURL(const Extension* extension) {
+  return Get(extension, keys::kHomepageURL).is_valid();
+}
+
+// static
+const GURL ManifestURL::GetManifestHomePageURL(const Extension* extension) {
+  const GURL& homepage_url = Get(extension, keys::kHomepageURL);
+  return homepage_url.is_valid() ? homepage_url : GURL::EmptyGURL();
+}
+
+// static
+const GURL ManifestURL::GetWebStoreURL(const Extension* extension) {
   bool use_webstore_url = UpdatesFromGallery(extension) &&
                           !SharedModuleInfo::IsSharedModule(extension);
   return use_webstore_url
@@ -46,11 +63,6 @@ const GURL ManifestURL::GetHomepageURL(const Extension* extension) {
              : GURL::EmptyGURL();
 }
 
-// static
-bool ManifestURL::SpecifiedHomepageURL(const Extension* extension) {
-  return Get(extension, keys::kHomepageURL).is_valid();
-}
-
 // static
 const GURL& ManifestURL::GetUpdateURL(const Extension* extension) {
   return Get(extension, keys::kUpdateURL);

extensions/common/manifest_url_handlers.h

@@ -6,6 +6,7 @@
 #define EXTENSIONS_COMMON_MANIFEST_URL_HANDLERS_H_
 
 #include <string>
+#include <vector>
 
 #include "base/macros.h"
 #include "extensions/common/extension.h"
@@ -29,12 +30,23 @@ struct ManifestURL : public Extension::ManifestData {
   // If homepage_url was not specified in the manifest,
   // this returns the Google Gallery URL. For third-party extensions,
   // this returns a blank GURL.
+  // See also: GetManifestHomePageURL(), SpecifiedHomepageURL()
   static const GURL GetHomepageURL(const Extension* extension);
 
   // Returns true if the extension specified a valid home page url in the
   // manifest.
   static bool SpecifiedHomepageURL(const Extension* extension);
 
+  // Returns the homepage specified by the extension in its manifest, if it
+  // specifies a homepage. Otherwise, returns an empty url.
+  // See also: GetHomepageURL()
+  static const GURL GetManifestHomePageURL(const Extension* extension);
+
+  // Returns the Chrome Web Store URL for this extension if it is hosted in the
+  // webstore; otherwise returns an empty url.
+  // See also: GetHomepageURL()
+  static const GURL GetWebStoreURL(const Extension* extension);
+
   // Returns the Update URL for this extension.
   static const GURL& GetUpdateURL(const Extension* extension);
 

third_party/closure_compiler/externs/developer_private.js

@@ -303,6 +303,7 @@ chrome.developerPrivate.Permission;
  *   location: !chrome.developerPrivate.Location,
  *   locationText: (string|undefined),
  *   manifestErrors: !Array<!chrome.developerPrivate.ManifestError>,
+ *   manifestHomePageUrl: string,
  *   mustRemainInstalled: boolean,
  *   name: string,
  *   offlineEnabled: boolean,
@@ -318,7 +319,8 @@ chrome.developerPrivate.Permission;
  *   updateUrl: string,
  *   userMayModify: boolean,
  *   version: string,
- *   views: !Array<!chrome.developerPrivate.ExtensionView>
+ *   views: !Array<!chrome.developerPrivate.ExtensionView>,
+ *   webStoreUrl: string
  * }}
  * @see https://developer.chrome.com/extensions/developerPrivate#type-ExtensionInfo
  */
@@ -734,7 +736,7 @@ chrome.developerPrivate.requestFileSource = function(properties, callback) {};
 chrome.developerPrivate.openDevTools = function(properties, callback) {};
 
 /**
- * Delete reported extension erors.
+ * Delete reported extension errors.
  * @param {!chrome.developerPrivate.DeleteExtensionErrorsProperties} properties
  *     The properties specifying the errors to remove.
  * @param {function():void=} callback