chromeos: Turn shortcut viewer app on by default unless a11y enabled

The app version of the shortcut viewer works well, but we're still
waiting on some accessibility support. Turn the app on by default, but
use the old version if certain a11y features are enabled.

Bug: 853883
Change-Id: I609b155da467bcb051d4d49d660de77863d0e1df
Reviewed-on: https://chromium-review.googlesource.com/1105077
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568242}

ash/public/cpp/ash_features.cc

@@ -23,7 +23,7 @@ const base::Feature kKeyboardShortcutViewer{"KeyboardShortcutViewer",
                                             base::FEATURE_ENABLED_BY_DEFAULT};
 
 const base::Feature kKeyboardShortcutViewerApp{
-    "KeyboardShortcutViewerApp", base::FEATURE_DISABLED_BY_DEFAULT};
+    "KeyboardShortcutViewerApp", base::FEATURE_ENABLED_BY_DEFAULT};
 
 const base::Feature kLockScreenNotifications{"LockScreenNotifications",
                                              base::FEATURE_DISABLED_BY_DEFAULT};

chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc

@@ -8,14 +8,27 @@
 #include "ash/components/shortcut_viewer/views/keyboard_shortcut_view.h"
 #include "ash/public/cpp/ash_features.h"
 #include "base/time/time.h"
+#include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
 #include "content/public/common/service_manager_connection.h"
 #include "services/service_manager/public/cpp/connector.h"
 
 namespace keyboard_shortcut_viewer_util {
+namespace {
+
+// Keyboard shortcut viewer app is incompatible with some a11y features.
+bool IsUsingA11yIncompatibleWithApp() {
+  chromeos::AccessibilityManager* a11y = chromeos::AccessibilityManager::Get();
+  return a11y->IsSpokenFeedbackEnabled() || a11y->IsCaretHighlightEnabled() ||
+         a11y->IsFocusHighlightEnabled() || a11y->IsSelectToSpeakEnabled() ||
+         a11y->IsSwitchAccessEnabled();
+}
+
+}  // namespace
 
 void ShowKeyboardShortcutViewer() {
   base::TimeTicks user_gesture_time = base::TimeTicks::Now();
-  if (ash::features::IsKeyboardShortcutViewerAppEnabled()) {
+  if (ash::features::IsKeyboardShortcutViewerAppEnabled() &&
+      !IsUsingA11yIncompatibleWithApp()) {
     shortcut_viewer::mojom::ShortcutViewerPtr shortcut_viewer_ptr;
     service_manager::Connector* connector =
         content::ServiceManagerConnection::GetForProcess()->GetConnector();