Commit 11b1eb7d authored by George Burgess IV's avatar George Burgess IV Committed by Commit Bot

blink_perf.parser: Reduce how much we recurse

Some of these tests caused blink to recurse to stacks > 4,000 frames
deep. This caused crashes for Android on ARM64, which has a standard
stack limit of 1MB.

Since it appears that these benchmarks' depths are somewhat arbitrary
(e.g. the crashes that we're seeing when running these benchmarks aren't
indicative of a problem in the real world), turning down the recursion
seems reasonable here.

New limits were chosen arbitrarily.

Bug: 851539
Test: Ran blink_perf.parser on ARM64 Android; no crashes observed.
Change-Id: I310b5e92fcb32524ec6e1c8a1c67226d68f4e5aa
Reviewed-on: https://chromium-review.googlesource.com/1111685
Commit-Queue: George Burgess <gbiv@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569720}
parent e8ff0342
......@@ -4,7 +4,7 @@
<script src="../resources/runner.js"></script>
<script>
var parentDiv = document.body;
for (var i = 0; i < 1000; i++) {
for (var i = 0; i < 500; i++) {
var div = document.createElement("div");
div.id = "foo" + i;
div.className = "bar" + i;
......
......@@ -4,7 +4,7 @@
<script src="../resources/runner.js"></script>
<script>
var parentDiv = document.body;
for (var i = 0; i < 1000; i++) {
for (var i = 0; i < 500; i++) {
var div = document.createElement("div");
div.id = "foo" + i;
div.className = "bar" + i;
......
......@@ -4,7 +4,7 @@
<script src="../resources/runner.js"></script>
<script>
var parentDiv = document.body;
for (var i = 0; i < 1000; i++) {
for (var i = 0; i < 500; i++) {
var div = document.createElement("div");
div.id = "foo" + i;
div.className = "bar" + i;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment