Commit 11cd89f6 authored by Morten Stenshorne's avatar Morten Stenshorne Committed by Commit Bot

Revert "Reenable PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword."

This reverts commit a2ce204c.

Reason for revert: Sorry, still flaky; see crbug.com/874380

Original change's description:
> Reenable PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword.
> 
> Bug: 791389
> Change-Id: Iea3b6e0f2ec7899e099bd9d7e23017ac4c83e459
> Reviewed-on: https://chromium-review.googlesource.com/1170908
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582537}

TBR=vasilii@chromium.org,dvadym@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 791389, 874380
Change-Id: I1551a9ae472ef3e6645622951bdfcd87f2fb74c7
Reviewed-on: https://chromium-review.googlesource.com/1175761Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583215}
parent 8784c77c
...@@ -300,8 +300,9 @@ IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest, ...@@ -300,8 +300,9 @@ IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
EXPECT_TRUE(GenerationPopupShowing()); EXPECT_TRUE(GenerationPopupShowing());
} }
// https://crbug.com/791389
IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest, IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
AutoSavingGeneratedPassword) { DISABLED_AutoSavingGeneratedPassword) {
scoped_refptr<password_manager::TestPasswordStore> password_store = scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>( static_cast<password_manager::TestPasswordStore*>(
PasswordStoreFactory::GetForProfile( PasswordStoreFactory::GetForProfile(
...@@ -318,7 +319,9 @@ IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest, ...@@ -318,7 +319,9 @@ IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
content::SimulateKeyPress(WebContents(), ui::DomKey::FromCharacter('U'), content::SimulateKeyPress(WebContents(), ui::DomKey::FromCharacter('U'),
ui::DomCode::US_U, ui::VKEY_U, false, false, false, ui::DomCode::US_U, ui::VKEY_U, false, false, false,
false); false);
WaitForElementValue("username_field", "U"); content::SimulateKeyPress(WebContents(), ui::DomKey::FromCharacter('N'),
ui::DomCode::US_N, ui::VKEY_N, false, false, false,
false);
// Submit form. // Submit form.
NavigationObserver observer(WebContents()); NavigationObserver observer(WebContents());
...@@ -335,6 +338,6 @@ IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest, ...@@ -335,6 +338,6 @@ IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
password_store->stored_passwords(); password_store->stored_passwords();
EXPECT_EQ(1u, stored_passwords.size()); EXPECT_EQ(1u, stored_passwords.size());
EXPECT_EQ(1u, stored_passwords.begin()->second.size()); EXPECT_EQ(1u, stored_passwords.begin()->second.size());
EXPECT_EQ(base::UTF8ToUTF16("U"), EXPECT_EQ(base::UTF8ToUTF16("UN"),
(stored_passwords.begin()->second)[0].username_value); (stored_passwords.begin()->second)[0].username_value);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment