Commit 11d1d2bf authored by dtseng's avatar dtseng Committed by Commit bot

Output group nodes as containers

See bug for more details.

In addition, abstract containers should output state since authors can apply aria state attributes on the node.

BUG=641769,641759
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2294363002
Cr-Commit-Position: refs/heads/master@{#416307}
parent 110b973f
......@@ -803,7 +803,9 @@ TEST_F('BackgroundTest', 'EditText', function() {
TEST_F('BackgroundTest', 'BackwardForwardSync', function() {
var mockFeedback = this.createMockFeedback();
this.runWithLoadedTree(function() {/*!
<div role="group" tabindex=0><input type="text"></input></div>
<div aria-label="Group" role="group" tabindex=0>
<input type="text"></input>
</div>
<ul>
<li tabindex=0>
<button>ok</button>
......
......@@ -186,7 +186,8 @@ Output.ROLE_INFO_ = {
msgId: 'role_grid'
},
group: {
msgId: 'role_group'
msgId: 'role_group',
inherits: 'abstractContainer'
},
heading: {
msgId: 'role_heading',
......@@ -419,7 +420,8 @@ Output.RULES = {
braille: ''
},
abstractContainer: {
enter: '$nameFromNode $role $description',
enter: '$nameFromNode $role $state $description',
speak: '$descendants $name $value $state $role $description',
leave: '@exited_container($role)'
},
alert: {
......@@ -439,6 +441,10 @@ Output.RULES = {
speak: '$if($checked, $earcon(CHECK_ON), $earcon(CHECK_OFF)) ' +
'$name $role $checked $description'
},
date: {
enter: '$nameFromNode $role $description',
speak: '$name $value $state $role $description'
},
dialog: {
enter: '$nameFromNode $role $description'
},
......@@ -449,6 +455,11 @@ Output.RULES = {
grid: {
enter: '$nameFromNode $role $description'
},
group: {
enter: '$nameFromNode $state $description',
speak: '$descendants $name $value $state $description',
leave: ''
},
heading: {
enter: '!relativePitch(hierarchicalLevel) ' +
'$nameFromNode= @tag_h+$hierarchicalLevel',
......@@ -458,6 +469,10 @@ Output.RULES = {
inlineTextBox: {
speak: '$name='
},
inputTime: {
enter: '$nameFromNode $role $description',
speak: '$name $value $state $role $description'
},
link: {
enter: '$nameFromNode= $if($visited, @visited_link, $role)',
speak: '$name= $if($visited, @visited_link, $role) $description'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment