Remove ModuleIntegrityVerification.RelocationsUnordered.

This metric shows that the number of failed verifications owing to
out-of-order relocations is double digits (has been in the low triple
digits within the past year). This is insignificant in the grand scheme
of things, so let's stop reporting it.

BUG=1088958
R=chromium-metrics-reviews@google.com, proberge@chromium.org

Change-Id: Ifc2c3e2d9ab407ddd978a4c028d16b079ab30041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435091
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811587}

chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

@@ -242,12 +242,11 @@ void CollectModuleVerificationData(
   using ModuleState = ClientIncidentReport_EnvironmentData_Process_ModuleState;
 
   for (size_t i = 0; i < num_modules_to_verify; ++i) {
-    std::unique_ptr<ModuleState> module_state(new ModuleState());
+    auto module_state = std::make_unique<ModuleState>();
 
     int num_bytes_different = 0;
-    bool scan_complete = VerifyModule(modules_to_verify[i],
-                                      module_state.get(),
-                                      &num_bytes_different);
+    VerifyModule(modules_to_verify[i], module_state.get(),
+                 &num_bytes_different);
 
     if (module_state->modified_state() == ModuleState::MODULE_STATE_UNMODIFIED)
       continue;
@@ -258,12 +257,6 @@ void CollectModuleVerificationData(
           num_bytes_different);
     }
 
-    if (!scan_complete) {
-      UMA_HISTOGRAM_EXACT_LINEAR(
-          "ModuleIntegrityVerification.RelocationsUnordered", i,
-          num_modules_to_verify);
-    }
-
     process->mutable_module_state()->AddAllocated(module_state.release());
   }
 #endif  // _WIN64

tools/metrics/histograms/enums.xml

@@ -48354,6 +48354,9 @@ Called by update_use_counter_css.py.-->
 </enum>
 
 <enum name="ModuleIndex">
+  <obsolete>
+    Removed in M87.
+  </obsolete>
   <int value="0" label="chrome.dll"/>
   <int value="1" label="chrome_elf.dll"/>
   <int value="2" label="ntdll.dll"/>

tools/metrics/histograms/histograms_xml/others/histograms.xml

@@ -8223,6 +8223,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
 
 <histogram name="ModuleIntegrityVerification.RelocationsUnordered"
     enum="ModuleIndex" expires_after="M85">
+  <obsolete>
+    Removed in M87.
+  </obsolete>
   <owner>grt@chromium.org</owner>
   <summary>
     Logged when the relocations in a module are not ordered causing the module