Commit 11da878c authored by Nate Fischer's avatar Nate Fischer Committed by Commit Bot

Android: use getDeclaredConstructor (errorprone warning)

No change to logic.

This uses getDeclaredConstructor to instantiate an instance for the
TestRunner. This propagates exceptions from the constructor, which means
we can log more error cases.

This resolves an errorprone compile warning (ClassNewInstance)

Test: ninja system_webview_apk (fewer warning messages)
Change-Id: I110b444ca93557d0ec138c2a05d8fda81904dfc8
Reviewed-on: https://chromium-review.googlesource.com/780808
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: default avataragrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518395}
parent 838dee73
...@@ -458,7 +458,9 @@ public abstract class Linker { ...@@ -458,7 +458,9 @@ public abstract class Linker {
} }
TestRunner testRunner = null; TestRunner testRunner = null;
try { try {
testRunner = (TestRunner) Class.forName(mTestRunnerClassName).newInstance(); testRunner = (TestRunner) Class.forName(mTestRunnerClassName)
.getDeclaredConstructor()
.newInstance();
} catch (Exception e) { } catch (Exception e) {
Log.wtf(TAG, "Could not instantiate test runner class by name", e); Log.wtf(TAG, "Could not instantiate test runner class by name", e);
assertForTesting(false); assertForTesting(false);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment