Expand runtime enabled feature plumbing's owners
Currently, runtime_enabled_features.json5, the central registry of Blink runtime-enabled features, has a relatively large OWNERS alias (to API owners and Blink core owners). Adding a new runtime-enabled feature associated with an embedder-side base::Feature often involves adding boilerplate to WebRuntimeFeatures and //content/child/runtime_features.cc. Unfortunately, these files are in far-removed directories with few common owners. This CL expands those files' per-file owners to include renderer/core's owners, just as blink/renderer/platform/OWNERS currently does for runtime_enabled_features.json5. For the case of content/child/runtime_features.cc, the change also adds all top-level Blink owners. This should reduce the number of approvals needed to land a new runtime-enabled feature. It might also improve the quality of scrutiny these changes get: the comments accompanying these OWNERS aliases (copied from the comment next to runtime_enabled_features.json5's OWNERS alias) require that the reviewers have context about the functionality being affected by the runtime-enabled feature; currently, it might be hard to find owners for public/platform, renderer/platform, and //content/child who have context on one's specific feature. Change-Id: If420895d0256347ca2831e835ef970f766420ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092905Reviewed-by:Kent Tamura <tkent@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749667}
Showing
Please register or sign in to comment