Commit 1208ff1c authored by Anders Hartvoll Ruud's avatar Anders Hartvoll Ruud Committed by Commit Bot

[mpc] Make [min-,max-][width,height] computed_value_comparable

Bug: 1057072
Change-Id: I3323687393ac07a05cc14f39b3076e66d8ba49d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207169
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: default avatarXiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771511}
parent 3dda524e
...@@ -2195,6 +2195,7 @@ ...@@ -2195,6 +2195,7 @@
default_value: "Length()", default_value: "Length()",
typedom_types: ["Keyword", "Length", "Percentage"], typedom_types: ["Keyword", "Length", "Percentage"],
converter: "ConvertLengthSizing", converter: "ConvertLengthSizing",
computed_value_comparable: true,
}, },
{ {
name: "hyphens", name: "hyphens",
...@@ -2518,7 +2519,8 @@ ...@@ -2518,7 +2519,8 @@
default_value: "Length::None()", default_value: "Length::None()",
converter: "ConvertLengthMaxSizing", converter: "ConvertLengthMaxSizing",
keywords: ["none"], keywords: ["none"],
typedom_types: ["Keyword", "Length", "Percentage"] typedom_types: ["Keyword", "Length", "Percentage"],
computed_value_comparable: true,
}, },
{ {
name: "max-width", name: "max-width",
...@@ -2530,7 +2532,8 @@ ...@@ -2530,7 +2532,8 @@
default_value: "Length::None()", default_value: "Length::None()",
converter: "ConvertLengthMaxSizing", converter: "ConvertLengthMaxSizing",
keywords: ["none"], keywords: ["none"],
typedom_types: ["Keyword", "Length", "Percentage"] typedom_types: ["Keyword", "Length", "Percentage"],
computed_value_comparable: true,
}, },
{ {
name: "min-height", name: "min-height",
...@@ -2541,7 +2544,8 @@ ...@@ -2541,7 +2544,8 @@
field_template: "<length>", field_template: "<length>",
default_value: "Length()", default_value: "Length()",
converter: "ConvertLengthSizing", converter: "ConvertLengthSizing",
typedom_types: ["Length", "Percentage"] typedom_types: ["Length", "Percentage"],
computed_value_comparable: true,
}, },
{ {
name: "min-width", name: "min-width",
...@@ -2552,7 +2556,8 @@ ...@@ -2552,7 +2556,8 @@
field_template: "<length>", field_template: "<length>",
default_value: "Length()", default_value: "Length()",
converter: "ConvertLengthSizing", converter: "ConvertLengthSizing",
typedom_types: ["Length", "Percentage"] typedom_types: ["Length", "Percentage"],
computed_value_comparable: true,
}, },
{ {
name: "mix-blend-mode", name: "mix-blend-mode",
...@@ -4500,6 +4505,7 @@ ...@@ -4500,6 +4505,7 @@
default_value: "Length()", default_value: "Length()",
typedom_types: ["Keyword", "Length", "Percentage"], typedom_types: ["Keyword", "Length", "Percentage"],
converter: "ConvertLengthSizing", converter: "ConvertLengthSizing",
computed_value_comparable: true,
}, },
{ {
name: "will-change", name: "will-change",
......
...@@ -141,6 +141,7 @@ namespace { ...@@ -141,6 +141,7 @@ namespace {
const char* color_examples[] = {"red", "green", "#fef", "#faf", nullptr}; const char* color_examples[] = {"red", "green", "#fef", "#faf", nullptr};
const char* direction_examples[] = {"ltr", "rtl", nullptr}; const char* direction_examples[] = {"ltr", "rtl", nullptr};
const char* length_or_auto_examples[] = {"auto", "1px", "2px", "5%", nullptr}; const char* length_or_auto_examples[] = {"auto", "1px", "2px", "5%", nullptr};
const char* length_or_none_examples[] = {"none", "1px", "2px", "5%", nullptr};
const char* vertical_align_examples[] = {"sub", "super", "1px", "3%", nullptr}; const char* vertical_align_examples[] = {"sub", "super", "1px", "3%", nullptr};
const char* writing_mode_examples[] = {"horizontal-tb", "vertical-rl", nullptr}; const char* writing_mode_examples[] = {"horizontal-tb", "vertical-rl", nullptr};
...@@ -155,10 +156,16 @@ struct ComputedValuesEqualData { ...@@ -155,10 +156,16 @@ struct ComputedValuesEqualData {
{"border-top-color", color_examples}, {"border-top-color", color_examples},
{"bottom", length_or_auto_examples}, {"bottom", length_or_auto_examples},
{"direction", direction_examples}, {"direction", direction_examples},
{"height", length_or_auto_examples},
{"left", length_or_auto_examples}, {"left", length_or_auto_examples},
{"max-height", length_or_none_examples},
{"max-width", length_or_none_examples},
{"min-height", length_or_auto_examples},
{"min-width", length_or_auto_examples},
{"right", length_or_auto_examples}, {"right", length_or_auto_examples},
{"top", length_or_auto_examples}, {"top", length_or_auto_examples},
{"vertical-align", vertical_align_examples}, {"vertical-align", vertical_align_examples},
{"width", length_or_auto_examples},
{"writing-mode", writing_mode_examples}, {"writing-mode", writing_mode_examples},
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment