Skip to content

GitLab

T
tangled
Commit 1218a0a9 authored by cfleizach@apple.com's avatar cfleizach@apple.com
Browse files
Options

Bug 25259: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link 

https://bugs.webkit.org/show_bug.cgi?id=25259

When a node becomes visible or hidden, accessibility needs to be told to update.



git-svn-id: svn://svn.chromium.org/blink/trunk@42611 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 81cdb45c
Hide whitespace changes
Inline Side-by-side
Showing with 75 additions and 3 deletions
third_party/WebKit/LayoutTests/ChangeLog
View file @ 1218a0a9
2009-04-17 Chris Fleizach <cfleizach@apple.com>
Reviewed by NOBODY Darin Adler.
Bug 25259: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
https://bugs.webkit.org/show_bug.cgi?id=25259
Add a test to make sure accessibility is updated when a node becomes visible or hidden.
* accessibility/visible-elements-expected.txt: Added.
* accessibility/visible-elements.html: Added.
2009-04-16 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Oliver Hunt.
......
third_party/WebKit/LayoutTests/accessibility/visible-elements.html 0 → 100644
View file @ 1218a0a9
<html>
<script>
if (window.layoutTestController)
layoutTestController.dumpAsText();
</script>
<body id="body">
<!-- This test ensures that a plugin that is not accessible, will not appear in the AX hierachy-->
<a href="#a">more</a><BR>
<div id="hiddenDiv" style="visibility: hidden; left: 0px; "><a href="#b">hello</a></div>
<div id="result"></div>
<script>
if (window.accessibilityController) {
var result = document.getElementById("result");
var body = document.getElementById("body");
body.focus();
var links1 = accessibilityController.focusedElement.attributesOfDocumentLinks();
// toggle the div
var divElement = document.getElementById("hiddenDiv");
divElement.style.visibility = "visible";
accessibilityController.focusedElement.attributesOfChildren();
var links2 = accessibilityController.focusedElement.attributesOfDocumentLinks();
if (links1 != links2) {
result.innerHTML += "PASS";
}
else {
result.innerHTML += "FAIL - The div's visibility was toggled, but the new link did not appear\n\n";
result.innerHTML += "Links1: " + links1 + "\n\nLinks2: " + links2 + "\n\n";
}
}
</script>
</body>
</html>
third_party/WebKit/WebCore/ChangeLog
View file @ 1218a0a9
2009-04-17 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
Bug 25259: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
https://bugs.webkit.org/show_bug.cgi?id=25259
When a node becomes visible or hidden, accessibility needs to be told to update.
Test: accessibility/visible-elements.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
2009-04-17 Kevin Ollivier <kevino@theolliviers.com>
wx build fix, added missing header.
third_party/WebKit/WebCore/rendering/RenderObject.cpp
View file @ 1218a0a9
......@@ -1546,12 +1546,15 @@ void RenderObject::styleWillChange(StyleDifference diff, const RenderStyle* newS
// If our z-index changes value or our visibility changes,
// we need to dirty our stacking context's z-order list.
if (newStyle) {
bool visibilityChanged = m_style->visibility() != newStyle->visibility()
|| m_style->zIndex() != newStyle->zIndex()
|| m_style->hasAutoZIndex() != newStyle->hasAutoZIndex();
#if ENABLE(DASHBOARD_SUPPORT)
if (m_style->visibility() != newStyle->visibility() ||
m_style->zIndex() != newStyle->zIndex() ||
m_style->hasAutoZIndex() != newStyle->hasAutoZIndex())
if (visibilityChanged)
document()->setDashboardRegionsDirty(true);
#endif
if (visibilityChanged && AXObjectCache::accessibilityEnabled())
document()->axObjectCache()->childrenChanged(this);
// Keep layer hierarchy visibility bits up to date if visibility changes.
if (m_style->visibility() != newStyle->visibility()) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment