Commit 12202482 authored by Lalit Maganti's avatar Lalit Maganti Committed by Commit Bot

memory-infra: enable full graph computation pipeline

Bug: 728199
Change-Id: I440814aa37c687ab68fea5717cee36a051a4908d
Reviewed-on: https://chromium-review.googlesource.com/800553Reviewed-by: default avatarPrimiano Tucci <primiano@chromium.org>
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523413}
parent c34e49db
......@@ -566,7 +566,10 @@ void GraphProcessor::CalculateSizeForNode(Node* node) {
// Check that if both aggregated and node sizes exist that the node size
// is bigger than the aggregated.
DCHECK(!node_size || !aggregated_size || *node_size >= *aggregated_size);
// TODO(lalitm): the following condition is triggered very often even though
// it is a warning in JS code. Find a way to add the warning to display in UI
// or to fix all instances where this is violated and then enable this check.
// DCHECK(!node_size || !aggregated_size || *node_size >= *aggregated_size);
// Calculate the maximal size of an owner node.
base::Optional<uint64_t> max_owner_size;
......@@ -580,7 +583,10 @@ void GraphProcessor::CalculateSizeForNode(Node* node) {
// Check that if both owner and node sizes exist that the node size
// is bigger than the owner.
DCHECK(!node_size || !max_owner_size || *node_size >= *max_owner_size);
// TODO(lalitm): the following condition is triggered very often even though
// it is a warning in JS code. Find a way to add the warning to display in UI
// or to fix all instances where this is violated and then enable this check.
// DCHECK(!node_size || !max_owner_size || *node_size >= *max_owner_size);
// Clear out any existing size entry which may exist.
node->entries()->erase(kSizeEntryName);
......
......@@ -247,6 +247,10 @@ void QueuedRequestDispatcher::Finalize(QueuedRequest* request,
std::map<base::ProcessId, uint64_t> shared_footprints =
GraphProcessor::ComputeSharedFootprintFromGraph(*global_graph);
// Perform the rest of the computation on the graph.
GraphProcessor::AddOverheadsAndPropogateEntries(global_graph.get());
GraphProcessor::CalculateSizesForGraph(global_graph.get());
// Build up the global dump by iterating on the |valid| process dumps.
mojom::GlobalMemoryDumpPtr global_dump(mojom::GlobalMemoryDump::New());
global_dump->process_dumps.reserve(request->responses.size());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment