Fix a crash by asynchronizing destruction.

BUG=145293

Review URL: https://chromiumcodereview.appspot.com/23441062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223616 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

@@ -16,6 +16,7 @@
 #include "chrome/browser/ui/website_settings/website_settings_utils.h"
 #include "chrome/common/content_settings_types.h"
 #include "chrome/common/url_constants.h"
+#include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cert_store.h"
 #include "content/public/browser/user_metrics.h"
 #include "grit/chromium_strings.h"
@@ -290,7 +291,8 @@ WebsiteSettingsPopupView::WebsiteSettingsPopupView(
       cert_id_(0),
       help_center_link_(NULL),
       connection_info_content_(NULL),
-      page_info_content_(NULL) {
+      page_info_content_(NULL),
+      weak_factory_(this) {
   // Compensate for built-in vertical padding in the anchor view's image.
   set_anchor_view_insets(gfx::Insets(kLocationIconVerticalMargin, 0,
                                      kLocationIconVerticalMargin, 0));
@@ -363,25 +365,13 @@ void WebsiteSettingsPopupView::ButtonPressed(
 
 void WebsiteSettingsPopupView::LinkClicked(views::Link* source,
                                            int event_flags) {
-  if (source == cookie_dialog_link_) {
-    // Count how often the Collected Cookies dialog is opened.
-    content::RecordAction(
-        content::UserMetricsAction("WebsiteSettings_CookiesDialogOpened"));
-    new CollectedCookiesViews(web_contents_);
-  } else if (source == certificate_dialog_link_) {
-    gfx::NativeWindow parent =
-        anchor_view() ? anchor_view()->GetWidget()->GetNativeWindow() : NULL;
-    ShowCertificateViewerByID(web_contents_, parent, cert_id_);
-  } else if (source == help_center_link_) {
-    browser_->OpenURL(content::OpenURLParams(
-        GURL(chrome::kPageInfoHelpCenterURL),
-        content::Referrer(),
-        NEW_FOREGROUND_TAB,
-        content::PAGE_TRANSITION_LINK,
-        false));
-  }
   // The popup closes automatically when the collected cookies dialog or the
-  // certificate viewer opens.
+  // certificate viewer opens. So delay handling of the link clicked to avoid
+  // a crash in the base class which needs to complete the mouse event handling.
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(&WebsiteSettingsPopupView::HandleLinkClickedAsync,
+                 weak_factory_.GetWeakPtr(), source));
 }
 
 void WebsiteSettingsPopupView::TabSelectedAt(int index) {
@@ -749,3 +739,26 @@ void WebsiteSettingsPopupView::ResetConnectionSection(
                   views::GridLayout::LEADING);
   layout->AddPaddingRow(0, kConnectionSectionPaddingBottom);
 }
+
+// Used to asynchronously handle clicks since these calls may cause the
+// destruction of the settings view and the base class window still
+// needs to be alive to finish handling the mouse click.
+void WebsiteSettingsPopupView::HandleLinkClickedAsync(views::Link* source) {
+  if (source == cookie_dialog_link_) {
+    // Count how often the Collected Cookies dialog is opened.
+    content::RecordAction(
+        content::UserMetricsAction("WebsiteSettings_CookiesDialogOpened"));
+    new CollectedCookiesViews(web_contents_);
+  } else if (source == certificate_dialog_link_) {
+    gfx::NativeWindow parent =
+        anchor_view() ? anchor_view()->GetWidget()->GetNativeWindow() : NULL;
+    ShowCertificateViewerByID(web_contents_, parent, cert_id_);
+  } else if (source == help_center_link_) {
+    browser_->OpenURL(content::OpenURLParams(
+        GURL(chrome::kPageInfoHelpCenterURL),
+        content::Referrer(),
+        NEW_FOREGROUND_TAB,
+        content::PAGE_TRANSITION_LINK,
+        false));
+  }
+}

chrome/browser/ui/views/website_settings/website_settings_popup_view.h

@@ -8,6 +8,7 @@
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/ui/views/website_settings/permission_selector_view_observer.h"
 #include "chrome/browser/ui/website_settings/website_settings_ui.h"
@@ -114,6 +115,8 @@ class WebsiteSettingsPopupView
                               const string16& headline,
                               const string16& text,
                               views::Link* link);
+  // Handles LinkClicked asynchronously.
+  void HandleLinkClickedAsync(views::Link* source);
 
   // The web contents of the current tab. The popup can't live longer than a
   // tab.
@@ -159,6 +162,8 @@ class WebsiteSettingsPopupView
   views::View* connection_info_content_;
   views::View* page_info_content_;
 
+  base::WeakPtrFactory<WebsiteSettingsPopupView> weak_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(WebsiteSettingsPopupView);
 };