Commit 122f1d2b authored by danakj's avatar danakj Committed by Commit bot

mojo: Don't put override on methods overriding blink interfaces.

Then we require 3 sided patches instead of 2 sided.

R=jamesr

Review URL: https://codereview.chromium.org/805893003

Cr-Commit-Position: refs/heads/master@{#308407}
parent ba3ef5d7
...@@ -67,42 +67,40 @@ class WebLayerTreeViewImpl : public blink::WebLayerTreeView, ...@@ -67,42 +67,40 @@ class WebLayerTreeViewImpl : public blink::WebLayerTreeView,
void RateLimitSharedMainThreadContext() override {} void RateLimitSharedMainThreadContext() override {}
// blink::WebLayerTreeView implementation. // blink::WebLayerTreeView implementation.
virtual void setSurfaceReady() override; virtual void setSurfaceReady();
virtual void setRootLayer(const blink::WebLayer& layer) override; virtual void setRootLayer(const blink::WebLayer& layer);
virtual void clearRootLayer() override; virtual void clearRootLayer();
virtual void setViewportSize( virtual void setViewportSize(const blink::WebSize& device_viewport_size);
const blink::WebSize& device_viewport_size) override; virtual blink::WebSize deviceViewportSize() const;
virtual blink::WebSize deviceViewportSize() const override; virtual void setDeviceScaleFactor(float);
virtual void setDeviceScaleFactor(float) override; virtual float deviceScaleFactor() const;
virtual float deviceScaleFactor() const override; virtual void setBackgroundColor(blink::WebColor color);
virtual void setBackgroundColor(blink::WebColor color) override; virtual void setHasTransparentBackground(bool has_transparent_background);
virtual void setHasTransparentBackground( virtual void setOverhangBitmap(const SkBitmap& bitmap);
bool has_transparent_background) override; virtual void setVisible(bool visible);
virtual void setOverhangBitmap(const SkBitmap& bitmap) override;
virtual void setVisible(bool visible) override;
virtual void setPageScaleFactorAndLimits(float page_scale_factor, virtual void setPageScaleFactorAndLimits(float page_scale_factor,
float minimum, float minimum,
float maximum) override; float maximum);
virtual void startPageScaleAnimation(const blink::WebPoint& destination, virtual void startPageScaleAnimation(const blink::WebPoint& destination,
bool use_anchor, bool use_anchor,
float new_page_scale, float new_page_scale,
double duration_sec) override; double duration_sec);
virtual void heuristicsForGpuRasterizationUpdated(bool matches_heuristic) {} virtual void heuristicsForGpuRasterizationUpdated(bool matches_heuristic) {}
virtual void setTopControlsContentOffset(float offset) {} virtual void setTopControlsContentOffset(float offset) {}
virtual void setNeedsAnimate() override; virtual void setNeedsAnimate();
virtual bool commitRequested() const override; virtual bool commitRequested() const;
virtual void didStopFlinging() {} virtual void didStopFlinging() {}
virtual void compositeAndReadbackAsync( virtual void compositeAndReadbackAsync(
blink::WebCompositeAndReadbackAsyncCallback* callback) {} blink::WebCompositeAndReadbackAsyncCallback* callback) {}
virtual void finishAllRendering() override; virtual void finishAllRendering();
virtual void setDeferCommits(bool defer_commits) {} virtual void setDeferCommits(bool defer_commits) {}
virtual void registerForAnimations(blink::WebLayer* layer) override; virtual void registerForAnimations(blink::WebLayer* layer);
virtual void registerViewportLayers( virtual void registerViewportLayers(
const blink::WebLayer* overscrollElasticityLayer, const blink::WebLayer* overscrollElasticityLayer,
const blink::WebLayer* pageScaleLayerLayer, const blink::WebLayer* pageScaleLayerLayer,
const blink::WebLayer* innerViewportScrollLayer, const blink::WebLayer* innerViewportScrollLayer,
const blink::WebLayer* outerViewportScrollLayer) override; const blink::WebLayer* outerViewportScrollLayer);
virtual void clearViewportLayers() override; virtual void clearViewportLayers();
virtual void registerSelection(const blink::WebSelectionBound& start, virtual void registerSelection(const blink::WebSelectionBound& start,
const blink::WebSelectionBound& end) {} const blink::WebSelectionBound& end) {}
virtual void clearSelection() {} virtual void clearSelection() {}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment