Commit 12318119 authored by Natalie Chouinard's avatar Natalie Chouinard Committed by Commit Bot

[Android] Rename About and Developer Settings fragments

Bug: 1030446
Change-Id: Id022b1d43b7359df768671fbb5562f53a8b21f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947549
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: default avatarBoris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721696}
parent 03823759
...@@ -1357,9 +1357,9 @@ chrome_java_sources = [ ...@@ -1357,9 +1357,9 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/settings/TextMessagePreference.java", "java/src/org/chromium/chrome/browser/settings/TextMessagePreference.java",
"java/src/org/chromium/chrome/browser/settings/TextScalePreference.java", "java/src/org/chromium/chrome/browser/settings/TextScalePreference.java",
"java/src/org/chromium/chrome/browser/settings/about/AboutChromePreferenceOSVersion.java", "java/src/org/chromium/chrome/browser/settings/about/AboutChromePreferenceOSVersion.java",
"java/src/org/chromium/chrome/browser/settings/about/AboutChromePreferences.java", "java/src/org/chromium/chrome/browser/settings/about/AboutChromeSettings.java",
"java/src/org/chromium/chrome/browser/settings/about/AboutSettingsBridge.java", "java/src/org/chromium/chrome/browser/settings/about/AboutSettingsBridge.java",
"java/src/org/chromium/chrome/browser/settings/about/LegalInformationPreferences.java", "java/src/org/chromium/chrome/browser/settings/about/LegalInformationSettings.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AndroidPaymentAppPreference.java", "java/src/org/chromium/chrome/browser/settings/autofill/AndroidPaymentAppPreference.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AndroidPaymentAppsFragment.java", "java/src/org/chromium/chrome/browser/settings/autofill/AndroidPaymentAppsFragment.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillCreditCardEditor.java", "java/src/org/chromium/chrome/browser/settings/autofill/AutofillCreditCardEditor.java",
...@@ -1377,9 +1377,9 @@ chrome_java_sources = [ ...@@ -1377,9 +1377,9 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionPreferenceFragment.java", "java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionPreferenceFragment.java",
"java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionSiteBreakdownView.java", "java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionSiteBreakdownView.java",
"java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionStatsPreference.java", "java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionStatsPreference.java",
"java/src/org/chromium/chrome/browser/settings/developer/DeveloperPreferences.java", "java/src/org/chromium/chrome/browser/settings/developer/DeveloperSettings.java",
"java/src/org/chromium/chrome/browser/settings/developer/TracingCategoriesPreferences.java", "java/src/org/chromium/chrome/browser/settings/developer/TracingCategoriesSettings.java",
"java/src/org/chromium/chrome/browser/settings/developer/TracingPreferences.java", "java/src/org/chromium/chrome/browser/settings/developer/TracingSettings.java",
"java/src/org/chromium/chrome/browser/settings/download/DownloadDirectoryAdapter.java", "java/src/org/chromium/chrome/browser/settings/download/DownloadDirectoryAdapter.java",
"java/src/org/chromium/chrome/browser/settings/download/DownloadLocationPreference.java", "java/src/org/chromium/chrome/browser/settings/download/DownloadLocationPreference.java",
"java/src/org/chromium/chrome/browser/settings/download/DownloadLocationPreferenceAdapter.java", "java/src/org/chromium/chrome/browser/settings/download/DownloadLocationPreferenceAdapter.java",
......
...@@ -413,7 +413,7 @@ chrome_test_java_sources = [ ...@@ -413,7 +413,7 @@ chrome_test_java_sources = [
"javatests/src/org/chromium/chrome/browser/settings/autofill/AutofillProfilesFragmentTest.java", "javatests/src/org/chromium/chrome/browser/settings/autofill/AutofillProfilesFragmentTest.java",
"javatests/src/org/chromium/chrome/browser/settings/autofill/AutofillTestRule.java", "javatests/src/org/chromium/chrome/browser/settings/autofill/AutofillTestRule.java",
"javatests/src/org/chromium/chrome/browser/settings/autofill_assistant/AutofillAssistantPreferencesTest.java", "javatests/src/org/chromium/chrome/browser/settings/autofill_assistant/AutofillAssistantPreferencesTest.java",
"javatests/src/org/chromium/chrome/browser/settings/developer/TracingPreferencesTest.java", "javatests/src/org/chromium/chrome/browser/settings/developer/TracingSettingsTest.java",
"javatests/src/org/chromium/chrome/browser/settings/password/SavePasswordsPreferencesTest.java", "javatests/src/org/chromium/chrome/browser/settings/password/SavePasswordsPreferencesTest.java",
"javatests/src/org/chromium/chrome/browser/settings/privacy/BrowsingDataBridgeTest.java", "javatests/src/org/chromium/chrome/browser/settings/privacy/BrowsingDataBridgeTest.java",
"javatests/src/org/chromium/chrome/browser/settings/privacy/BrowsingDataTest.java", "javatests/src/org/chromium/chrome/browser/settings/privacy/BrowsingDataTest.java",
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
android:key="os_version" android:key="os_version"
android:title="@string/os_version_title" /> android:title="@string/os_version_title" />
<Preference <Preference
android:fragment="org.chromium.chrome.browser.settings.about.LegalInformationPreferences" android:fragment="org.chromium.chrome.browser.settings.about.LegalInformationSettings"
android:key="legal_information" android:key="legal_information"
android:title="@string/legal_information_title" /> android:title="@string/legal_information_title" />
</PreferenceScreen> </PreferenceScreen>
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto"
android:orderingFromXml="true"> android:orderingFromXml="true">
<Preference <Preference
android:fragment="org.chromium.chrome.browser.settings.developer.TracingPreferences" android:fragment="org.chromium.chrome.browser.settings.developer.TracingSettings"
android:key="tracing" android:key="tracing"
android:title="Tracing" /> android:title="Tracing" />
<org.chromium.chrome.browser.settings.TextMessagePreference <org.chromium.chrome.browser.settings.TextMessagePreference
......
...@@ -101,12 +101,12 @@ ...@@ -101,12 +101,12 @@
android:order="18" android:order="18"
android:title="@string/menu_downloads"/> android:title="@string/menu_downloads"/>
<Preference <Preference
android:fragment="org.chromium.chrome.browser.settings.developer.DeveloperPreferences" android:fragment="org.chromium.chrome.browser.settings.developer.DeveloperSettings"
android:key="developer" android:key="developer"
android:order="19" android:order="19"
android:title="Developer options"/> android:title="Developer options"/>
<Preference <Preference
android:fragment="org.chromium.chrome.browser.settings.about.AboutChromePreferences" android:fragment="org.chromium.chrome.browser.settings.about.AboutChromeSettings"
android:key="about_chrome" android:key="about_chrome"
android:order="20" android:order="20"
android:title="@string/prefs_about_chrome"/> android:title="@string/prefs_about_chrome"/>
......
...@@ -7,11 +7,11 @@ ...@@ -7,11 +7,11 @@
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto"
android:orderingFromXml="true"> android:orderingFromXml="true">
<Preference <Preference
android:fragment="org.chromium.chrome.browser.settings.developer.TracingCategoriesPreferences" android:fragment="org.chromium.chrome.browser.settings.developer.TracingCategoriesSettings"
android:key="default_categories" android:key="default_categories"
android:title="Default categories"/><!-- developer strings are not translated --> android:title="Default categories"/><!-- developer strings are not translated -->
<Preference <Preference
android:fragment="org.chromium.chrome.browser.settings.developer.TracingCategoriesPreferences" android:fragment="org.chromium.chrome.browser.settings.developer.TracingCategoriesSettings"
android:key="non_default_categories" android:key="non_default_categories"
android:title="Disabled-by-default categories"/> android:title="Disabled-by-default categories"/>
<ListPreference <ListPreference
......
...@@ -28,7 +28,7 @@ import org.chromium.chrome.browser.password_manager.PasswordManagerLauncher; ...@@ -28,7 +28,7 @@ import org.chromium.chrome.browser.password_manager.PasswordManagerLauncher;
import org.chromium.chrome.browser.search_engines.TemplateUrlServiceFactory; import org.chromium.chrome.browser.search_engines.TemplateUrlServiceFactory;
import org.chromium.chrome.browser.settings.autofill_assistant.AutofillAssistantPreferences; import org.chromium.chrome.browser.settings.autofill_assistant.AutofillAssistantPreferences;
import org.chromium.chrome.browser.settings.datareduction.DataReductionPreferenceFragment; import org.chromium.chrome.browser.settings.datareduction.DataReductionPreferenceFragment;
import org.chromium.chrome.browser.settings.developer.DeveloperPreferences; import org.chromium.chrome.browser.settings.developer.DeveloperSettings;
import org.chromium.chrome.browser.settings.sync.SignInPreference; import org.chromium.chrome.browser.settings.sync.SignInPreference;
import org.chromium.chrome.browser.settings.sync.SyncPreferenceUtils; import org.chromium.chrome.browser.settings.sync.SyncPreferenceUtils;
import org.chromium.chrome.browser.signin.IdentityServicesProvider; import org.chromium.chrome.browser.signin.IdentityServicesProvider;
...@@ -217,7 +217,7 @@ public class MainPreferences extends PreferenceFragmentCompat ...@@ -217,7 +217,7 @@ public class MainPreferences extends PreferenceFragmentCompat
removePreferenceIfPresent(PREF_UI_THEME); removePreferenceIfPresent(PREF_UI_THEME);
} }
if (DeveloperPreferences.shouldShowDeveloperPreferences()) { if (DeveloperSettings.shouldShowDeveloperSettings()) {
addPreferenceIfAbsent(PREF_DEVELOPER); addPreferenceIfAbsent(PREF_DEVELOPER);
} else { } else {
removePreferenceIfPresent(PREF_DEVELOPER); removePreferenceIfPresent(PREF_DEVELOPER);
......
...@@ -15,7 +15,7 @@ import android.text.format.DateUtils; ...@@ -15,7 +15,7 @@ import android.text.format.DateUtils;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeVersionInfo; import org.chromium.chrome.browser.ChromeVersionInfo;
import org.chromium.chrome.browser.settings.SettingsUtils; import org.chromium.chrome.browser.settings.SettingsUtils;
import org.chromium.chrome.browser.settings.developer.DeveloperPreferences; import org.chromium.chrome.browser.settings.developer.DeveloperSettings;
import org.chromium.ui.widget.Toast; import org.chromium.ui.widget.Toast;
import java.util.Calendar; import java.util.Calendar;
...@@ -23,9 +23,9 @@ import java.util.Calendar; ...@@ -23,9 +23,9 @@ import java.util.Calendar;
/** /**
* Settings fragment that displays information about Chrome. * Settings fragment that displays information about Chrome.
*/ */
public class AboutChromePreferences public class AboutChromeSettings
extends PreferenceFragmentCompat implements Preference.OnPreferenceClickListener { extends PreferenceFragmentCompat implements Preference.OnPreferenceClickListener {
private static final int TAPS_FOR_DEVELOPER_PREFERENCES = 7; private static final int TAPS_FOR_DEVELOPER_SETTINGS = 7;
private static final String PREF_APPLICATION_VERSION = "application_version"; private static final String PREF_APPLICATION_VERSION = "application_version";
private static final String PREF_OS_VERSION = "os_version"; private static final String PREF_OS_VERSION = "os_version";
...@@ -40,9 +40,8 @@ public class AboutChromePreferences ...@@ -40,9 +40,8 @@ public class AboutChromePreferences
private static final String MSG_DEVELOPER_ALREADY_ENABLED = private static final String MSG_DEVELOPER_ALREADY_ENABLED =
"Developer options are already enabled."; "Developer options are already enabled.";
private int mDeveloperHitCountdown = DeveloperPreferences.shouldShowDeveloperPreferences() private int mDeveloperHitCountdown =
? -1 DeveloperSettings.shouldShowDeveloperSettings() ? -1 : TAPS_FOR_DEVELOPER_SETTINGS;
: TAPS_FOR_DEVELOPER_PREFERENCES;
private Toast mToast; private Toast mToast;
@Override @Override
...@@ -88,16 +87,16 @@ public class AboutChromePreferences ...@@ -88,16 +87,16 @@ public class AboutChromePreferences
mDeveloperHitCountdown--; mDeveloperHitCountdown--;
if (mDeveloperHitCountdown == 0) { if (mDeveloperHitCountdown == 0) {
DeveloperPreferences.setDeveloperPreferencesEnabled(); DeveloperSettings.setDeveloperSettingsEnabled();
// Show a toast that the developer preferences were enabled. // Show a toast that the developer settings were enabled.
if (mToast != null) { if (mToast != null) {
mToast.cancel(); mToast.cancel();
} }
mToast = Toast.makeText(getActivity(), MSG_DEVELOPER_ENABLED, Toast.LENGTH_LONG); mToast = Toast.makeText(getActivity(), MSG_DEVELOPER_ENABLED, Toast.LENGTH_LONG);
mToast.show(); mToast.show();
} else if (mDeveloperHitCountdown > 0 } else if (mDeveloperHitCountdown > 0
&& mDeveloperHitCountdown < (TAPS_FOR_DEVELOPER_PREFERENCES - 2)) { && mDeveloperHitCountdown < (TAPS_FOR_DEVELOPER_SETTINGS - 2)) {
// Show a countdown toast. // Show a countdown toast.
if (mToast != null) { if (mToast != null) {
mToast.cancel(); mToast.cancel();
...@@ -112,7 +111,7 @@ public class AboutChromePreferences ...@@ -112,7 +111,7 @@ public class AboutChromePreferences
mToast.show(); mToast.show();
} }
} else if (mDeveloperHitCountdown < 0) { } else if (mDeveloperHitCountdown < 0) {
// Show a toast that the developer preferences are already enabled. // Show a toast that the developer settings are already enabled.
if (mToast != null) { if (mToast != null) {
mToast.cancel(); mToast.cancel();
} }
......
...@@ -13,7 +13,7 @@ import org.chromium.chrome.browser.settings.SettingsUtils; ...@@ -13,7 +13,7 @@ import org.chromium.chrome.browser.settings.SettingsUtils;
/** /**
* Fragment to display legal information about Chrome. * Fragment to display legal information about Chrome.
*/ */
public class LegalInformationPreferences extends PreferenceFragmentCompat { public class LegalInformationSettings extends PreferenceFragmentCompat {
@Override @Override
public void onCreatePreferences(Bundle savedInstanceState, String s) { public void onCreatePreferences(Bundle savedInstanceState, String s) {
SettingsUtils.addPreferencesFromResource(this, R.xml.legal_information_preferences); SettingsUtils.addPreferencesFromResource(this, R.xml.legal_information_preferences);
......
...@@ -17,21 +17,21 @@ import org.chromium.components.version_info.VersionConstants; ...@@ -17,21 +17,21 @@ import org.chromium.components.version_info.VersionConstants;
/** /**
* Settings fragment containing preferences aimed at Chrome and web developers. * Settings fragment containing preferences aimed at Chrome and web developers.
*/ */
public class DeveloperPreferences extends PreferenceFragmentCompat { public class DeveloperSettings extends PreferenceFragmentCompat {
private static final String UI_PREF_BETA_STABLE_HINT = "beta_stable_hint"; private static final String UI_PREF_BETA_STABLE_HINT = "beta_stable_hint";
private static final String PREF_DEVELOPER_ENABLED = "developer"; private static final String PREF_DEVELOPER_ENABLED = "developer";
// Non-translated strings: // Non-translated strings:
private static final String MSG_DEVELOPER_OPTIONS_TITLE = "Developer options"; private static final String MSG_DEVELOPER_OPTIONS_TITLE = "Developer options";
public static boolean shouldShowDeveloperPreferences() { public static boolean shouldShowDeveloperSettings() {
// Always enabled on canary, dev and local builds, otherwise can be enabled by tapping the // Always enabled on canary, dev and local builds, otherwise can be enabled by tapping the
// Chrome version in Settings>About multiple times. // Chrome version in Settings>About multiple times.
if (VersionConstants.CHANNEL <= Channel.DEV) return true; if (VersionConstants.CHANNEL <= Channel.DEV) return true;
return ContextUtils.getAppSharedPreferences().getBoolean(PREF_DEVELOPER_ENABLED, false); return ContextUtils.getAppSharedPreferences().getBoolean(PREF_DEVELOPER_ENABLED, false);
} }
public static void setDeveloperPreferencesEnabled() { public static void setDeveloperSettingsEnabled() {
ContextUtils.getAppSharedPreferences() ContextUtils.getAppSharedPreferences()
.edit() .edit()
.putBoolean(PREF_DEVELOPER_ENABLED, true) .putBoolean(PREF_DEVELOPER_ENABLED, true)
......
...@@ -25,7 +25,7 @@ import java.util.Set; ...@@ -25,7 +25,7 @@ import java.util.Set;
* Settings fragment that configures chrome tracing categories of a specific type. The type is * Settings fragment that configures chrome tracing categories of a specific type. The type is
* passed to the fragment via an extra (EXTRA_CATEGORY_TYPE). * passed to the fragment via an extra (EXTRA_CATEGORY_TYPE).
*/ */
public class TracingCategoriesPreferences public class TracingCategoriesSettings
extends PreferenceFragmentCompat implements Preference.OnPreferenceChangeListener { extends PreferenceFragmentCompat implements Preference.OnPreferenceChangeListener {
public static final String EXTRA_CATEGORY_TYPE = "type"; public static final String EXTRA_CATEGORY_TYPE = "type";
...@@ -35,7 +35,7 @@ public class TracingCategoriesPreferences ...@@ -35,7 +35,7 @@ public class TracingCategoriesPreferences
private static final String SELECT_ALL_KEY = "select-all"; private static final String SELECT_ALL_KEY = "select-all";
private static final String SELECT_ALL_TITLE = "Select all"; private static final String SELECT_ALL_TITLE = "Select all";
private @TracingPreferences.CategoryType int mType; private @TracingSettings.CategoryType int mType;
private Set<String> mEnabledCategories; private Set<String> mEnabledCategories;
private List<CheckBoxPreference> mAllPreferences; private List<CheckBoxPreference> mAllPreferences;
private CheckBoxPreference mSelectAllPreference; private CheckBoxPreference mSelectAllPreference;
...@@ -48,7 +48,7 @@ public class TracingCategoriesPreferences ...@@ -48,7 +48,7 @@ public class TracingCategoriesPreferences
preferenceScreen.setOrderingAsAdded(true); preferenceScreen.setOrderingAsAdded(true);
mType = getArguments().getInt(EXTRA_CATEGORY_TYPE); mType = getArguments().getInt(EXTRA_CATEGORY_TYPE);
mEnabledCategories = new HashSet<>(TracingPreferences.getEnabledCategories(mType)); mEnabledCategories = new HashSet<>(TracingSettings.getEnabledCategories(mType));
mAllPreferences = new ArrayList<>(); mAllPreferences = new ArrayList<>();
List<String> sortedCategories = List<String> sortedCategories =
...@@ -64,7 +64,7 @@ public class TracingCategoriesPreferences ...@@ -64,7 +64,7 @@ public class TracingCategoriesPreferences
preferenceScreen.addPreference(mSelectAllPreference); preferenceScreen.addPreference(mSelectAllPreference);
for (String category : sortedCategories) { for (String category : sortedCategories) {
if (TracingPreferences.getCategoryType(category) == mType) { if (TracingSettings.getCategoryType(category) == mType) {
CheckBoxPreference pref = createPreference(category); CheckBoxPreference pref = createPreference(category);
mAllPreferences.add(pref); mAllPreferences.add(pref);
preferenceScreen.addPreference(pref); preferenceScreen.addPreference(pref);
...@@ -77,9 +77,8 @@ public class TracingCategoriesPreferences ...@@ -77,9 +77,8 @@ public class TracingCategoriesPreferences
private CheckBoxPreference createPreference(String category) { private CheckBoxPreference createPreference(String category) {
CheckBoxPreference preference = new ChromeBaseCheckBoxPreference(getStyledContext(), null); CheckBoxPreference preference = new ChromeBaseCheckBoxPreference(getStyledContext(), null);
preference.setKey(category); preference.setKey(category);
preference.setTitle(category.startsWith(TracingPreferences.NON_DEFAULT_CATEGORY_PREFIX) preference.setTitle(category.startsWith(TracingSettings.NON_DEFAULT_CATEGORY_PREFIX)
? category.substring( ? category.substring(TracingSettings.NON_DEFAULT_CATEGORY_PREFIX.length())
TracingPreferences.NON_DEFAULT_CATEGORY_PREFIX.length())
: category); : category);
preference.setChecked(mEnabledCategories.contains(category)); preference.setChecked(mEnabledCategories.contains(category));
preference.setPersistent(false); // We persist the preference value ourselves. preference.setPersistent(false); // We persist the preference value ourselves.
...@@ -101,7 +100,7 @@ public class TracingCategoriesPreferences ...@@ -101,7 +100,7 @@ public class TracingCategoriesPreferences
mEnabledCategories.remove(preference.getKey()); mEnabledCategories.remove(preference.getKey());
} }
mSelectAllPreference.setChecked(mEnabledCategories.size() == mAllPreferences.size()); mSelectAllPreference.setChecked(mEnabledCategories.size() == mAllPreferences.size());
TracingPreferences.setEnabledCategories(mType, mEnabledCategories); TracingSettings.setEnabledCategories(mType, mEnabledCategories);
return true; return true;
} }
......
...@@ -28,7 +28,7 @@ import java.util.Set; ...@@ -28,7 +28,7 @@ import java.util.Set;
/** /**
* Settings fragment that shows options for recording a performance trace. * Settings fragment that shows options for recording a performance trace.
*/ */
public class TracingPreferences public class TracingSettings
extends PreferenceFragmentCompat implements TracingController.Observer { extends PreferenceFragmentCompat implements TracingController.Observer {
static final String NON_DEFAULT_CATEGORY_PREFIX = "disabled-by-default-"; static final String NON_DEFAULT_CATEGORY_PREFIX = "disabled-by-default-";
...@@ -190,10 +190,10 @@ public class TracingPreferences ...@@ -190,10 +190,10 @@ public class TracingPreferences
mPrefTracingStatus = findPreference(UI_PREF_TRACING_STATUS); mPrefTracingStatus = findPreference(UI_PREF_TRACING_STATUS);
mPrefDefaultCategories.getExtras().putInt( mPrefDefaultCategories.getExtras().putInt(
TracingCategoriesPreferences.EXTRA_CATEGORY_TYPE, CategoryType.DEFAULT); TracingCategoriesSettings.EXTRA_CATEGORY_TYPE, CategoryType.DEFAULT);
mPrefNondefaultCategories.getExtras().putInt( mPrefNondefaultCategories.getExtras().putInt(
TracingCategoriesPreferences.EXTRA_CATEGORY_TYPE, CategoryType.NON_DEFAULT); TracingCategoriesSettings.EXTRA_CATEGORY_TYPE, CategoryType.NON_DEFAULT);
mPrefMode.setEntryValues(TRACING_MODES.keySet().toArray(new String[TRACING_MODES.size()])); mPrefMode.setEntryValues(TRACING_MODES.keySet().toArray(new String[TRACING_MODES.size()]));
String[] descriptions = String[] descriptions =
......
...@@ -38,7 +38,7 @@ import org.chromium.chrome.browser.init.EmptyBrowserParts; ...@@ -38,7 +38,7 @@ import org.chromium.chrome.browser.init.EmptyBrowserParts;
import org.chromium.chrome.browser.notifications.channels.SiteChannelsManager; import org.chromium.chrome.browser.notifications.channels.SiteChannelsManager;
import org.chromium.chrome.browser.searchwidget.SearchWidgetProvider; import org.chromium.chrome.browser.searchwidget.SearchWidgetProvider;
import org.chromium.chrome.browser.settings.PreferencesLauncher; import org.chromium.chrome.browser.settings.PreferencesLauncher;
import org.chromium.chrome.browser.settings.about.AboutChromePreferences; import org.chromium.chrome.browser.settings.about.AboutChromeSettings;
import org.chromium.chrome.browser.settings.website.Website.StoredDataClearedCallback; import org.chromium.chrome.browser.settings.website.Website.StoredDataClearedCallback;
import org.chromium.chrome.browser.util.ConversionUtils; import org.chromium.chrome.browser.util.ConversionUtils;
...@@ -124,7 +124,7 @@ public class ManageSpaceActivity extends AppCompatActivity implements View.OnCli ...@@ -124,7 +124,7 @@ public class ManageSpaceActivity extends AppCompatActivity implements View.OnCli
// kicking off the browser process initialization. // kicking off the browser process initialization.
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskWrites(); StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskWrites();
try { try {
String productVersion = AboutChromePreferences.getApplicationVersion( String productVersion = AboutChromeSettings.getApplicationVersion(
this, ChromeVersionInfo.getProductVersion()); this, ChromeVersionInfo.getProductVersion());
String failedVersion = ContextUtils.getAppSharedPreferences().getString( String failedVersion = ContextUtils.getAppSharedPreferences().getString(
PREF_FAILED_BUILD_VERSION, null); PREF_FAILED_BUILD_VERSION, null);
......
...@@ -20,7 +20,7 @@ import org.chromium.base.ObserverList; ...@@ -20,7 +20,7 @@ import org.chromium.base.ObserverList;
import org.chromium.base.task.AsyncTask; import org.chromium.base.task.AsyncTask;
import org.chromium.base.task.PostTask; import org.chromium.base.task.PostTask;
import org.chromium.base.task.TaskTraits; import org.chromium.base.task.TaskTraits;
import org.chromium.chrome.browser.settings.developer.TracingPreferences; import org.chromium.chrome.browser.settings.developer.TracingSettings;
import org.chromium.content_public.browser.TracingControllerAndroid; import org.chromium.content_public.browser.TracingControllerAndroid;
import org.chromium.content_public.browser.UiThreadTaskTraits; import org.chromium.content_public.browser.UiThreadTaskTraits;
import org.chromium.ui.widget.Toast; import org.chromium.ui.widget.Toast;
...@@ -239,8 +239,8 @@ public class TracingController { ...@@ -239,8 +239,8 @@ public class TracingController {
assert mState == State.STARTING; assert mState == State.STARTING;
// TODO(eseckler): TracingControllerAndroid currently doesn't support a json trace config. // TODO(eseckler): TracingControllerAndroid currently doesn't support a json trace config.
String categories = TextUtils.join(",", TracingPreferences.getEnabledCategories()); String categories = TextUtils.join(",", TracingSettings.getEnabledCategories());
String options = TracingPreferences.getSelectedTracingMode(); String options = TracingSettings.getSelectedTracingMode();
if (!mNativeController.startTracing( if (!mNativeController.startTracing(
mTracingTempFile.getPath(), false, categories, options, true)) { mTracingTempFile.getPath(), false, categories, options, true)) {
......
...@@ -56,7 +56,7 @@ import java.util.concurrent.TimeUnit; ...@@ -56,7 +56,7 @@ import java.util.concurrent.TimeUnit;
*/ */
@RunWith(ChromeJUnit4ClassRunner.class) @RunWith(ChromeJUnit4ClassRunner.class)
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE}) @CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE})
public class TracingPreferencesTest { public class TracingSettingsTest {
@Rule @Rule
public final ChromeActivityTestRule<ChromeActivity> mActivityTestRule = public final ChromeActivityTestRule<ChromeActivity> mActivityTestRule =
new ChromeActivityTestRule<>(ChromeActivity.class); new ChromeActivityTestRule<>(ChromeActivity.class);
...@@ -104,12 +104,12 @@ public class TracingPreferencesTest { ...@@ -104,12 +104,12 @@ public class TracingPreferencesTest {
private void waitForTracingControllerInitialization(PreferenceFragmentCompat fragment) private void waitForTracingControllerInitialization(PreferenceFragmentCompat fragment)
throws Exception { throws Exception {
final Preference defaultCategoriesPref = final Preference defaultCategoriesPref =
fragment.findPreference(TracingPreferences.UI_PREF_DEFAULT_CATEGORIES); fragment.findPreference(TracingSettings.UI_PREF_DEFAULT_CATEGORIES);
final Preference nonDefaultCategoriesPref = final Preference nonDefaultCategoriesPref =
fragment.findPreference(TracingPreferences.UI_PREF_NON_DEFAULT_CATEGORIES); fragment.findPreference(TracingSettings.UI_PREF_NON_DEFAULT_CATEGORIES);
final Preference modePref = fragment.findPreference(TracingPreferences.UI_PREF_MODE); final Preference modePref = fragment.findPreference(TracingSettings.UI_PREF_MODE);
final Preference startTracingButton = final Preference startTracingButton =
fragment.findPreference(TracingPreferences.UI_PREF_START_RECORDING); fragment.findPreference(TracingSettings.UI_PREF_START_RECORDING);
CallbackHelper callbackHelper = new CallbackHelper(); CallbackHelper callbackHelper = new CallbackHelper();
TestThreadUtils.runOnUiThreadBlocking(() -> { TestThreadUtils.runOnUiThreadBlocking(() -> {
...@@ -143,11 +143,11 @@ public class TracingPreferencesTest { ...@@ -143,11 +143,11 @@ public class TracingPreferencesTest {
public void testRecordTrace() throws Exception { public void testRecordTrace() throws Exception {
mActivityTestRule.startMainActivityOnBlankPage(); mActivityTestRule.startMainActivityOnBlankPage();
SettingsActivity activity = SettingsActivity activity =
mActivityTestRule.startSettingsActivity(TracingPreferences.class.getName()); mActivityTestRule.startSettingsActivity(TracingSettings.class.getName());
final PreferenceFragmentCompat fragment = final PreferenceFragmentCompat fragment =
(PreferenceFragmentCompat) activity.getMainFragment(); (PreferenceFragmentCompat) activity.getMainFragment();
final ButtonPreference startTracingButton = (ButtonPreference) fragment.findPreference( final ButtonPreference startTracingButton =
TracingPreferences.UI_PREF_START_RECORDING); (ButtonPreference) fragment.findPreference(TracingSettings.UI_PREF_START_RECORDING);
waitForTracingControllerInitialization(fragment); waitForTracingControllerInitialization(fragment);
...@@ -160,7 +160,7 @@ public class TracingPreferencesTest { ...@@ -160,7 +160,7 @@ public class TracingPreferencesTest {
Assert.assertEquals( Assert.assertEquals(
TracingController.State.IDLE, TracingController.getInstance().getState()); TracingController.State.IDLE, TracingController.getInstance().getState());
Assert.assertTrue(startTracingButton.isEnabled()); Assert.assertTrue(startTracingButton.isEnabled());
Assert.assertEquals(TracingPreferences.MSG_START, startTracingButton.getTitle()); Assert.assertEquals(TracingSettings.MSG_START, startTracingButton.getTitle());
// Tap the button to start recording a trace. // Tap the button to start recording a trace.
startTracingButton.performClick(); startTracingButton.performClick();
...@@ -168,7 +168,7 @@ public class TracingPreferencesTest { ...@@ -168,7 +168,7 @@ public class TracingPreferencesTest {
Assert.assertEquals( Assert.assertEquals(
TracingController.State.STARTING, TracingController.getInstance().getState()); TracingController.State.STARTING, TracingController.getInstance().getState());
Assert.assertFalse(startTracingButton.isEnabled()); Assert.assertFalse(startTracingButton.isEnabled());
Assert.assertEquals(TracingPreferences.MSG_ACTIVE, startTracingButton.getTitle()); Assert.assertEquals(TracingSettings.MSG_ACTIVE, startTracingButton.getTitle());
// Observe state changes to RECORDING, STOPPING, STOPPED, and IDLE. // Observe state changes to RECORDING, STOPPING, STOPPED, and IDLE.
TracingController.getInstance().addObserver(new TracingController.Observer() { TracingController.getInstance().addObserver(new TracingController.Observer() {
...@@ -243,20 +243,20 @@ public class TracingPreferencesTest { ...@@ -243,20 +243,20 @@ public class TracingPreferencesTest {
mMockNotificationManager.setNotificationsEnabled(false); mMockNotificationManager.setNotificationsEnabled(false);
SettingsActivity activity = SettingsActivity activity =
mActivityTestRule.startSettingsActivity(TracingPreferences.class.getName()); mActivityTestRule.startSettingsActivity(TracingSettings.class.getName());
final PreferenceFragmentCompat fragment = final PreferenceFragmentCompat fragment =
(PreferenceFragmentCompat) activity.getMainFragment(); (PreferenceFragmentCompat) activity.getMainFragment();
final ButtonPreference startTracingButton = (ButtonPreference) fragment.findPreference( final ButtonPreference startTracingButton =
TracingPreferences.UI_PREF_START_RECORDING); (ButtonPreference) fragment.findPreference(TracingSettings.UI_PREF_START_RECORDING);
final TextMessagePreference statusPreference = final TextMessagePreference statusPreference =
(TextMessagePreference) fragment.findPreference( (TextMessagePreference) fragment.findPreference(
TracingPreferences.UI_PREF_TRACING_STATUS); TracingSettings.UI_PREF_TRACING_STATUS);
waitForTracingControllerInitialization(fragment); waitForTracingControllerInitialization(fragment);
Assert.assertFalse(startTracingButton.isEnabled()); Assert.assertFalse(startTracingButton.isEnabled());
Assert.assertEquals( Assert.assertEquals(
TracingPreferences.MSG_NOTIFICATIONS_DISABLED, statusPreference.getTitle()); TracingSettings.MSG_NOTIFICATIONS_DISABLED, statusPreference.getTitle());
mMockNotificationManager.setNotificationsEnabled(true); mMockNotificationManager.setNotificationsEnabled(true);
} }
...@@ -268,13 +268,13 @@ public class TracingPreferencesTest { ...@@ -268,13 +268,13 @@ public class TracingPreferencesTest {
// We need a renderer so that its tracing categories will be populated. // We need a renderer so that its tracing categories will be populated.
mActivityTestRule.startMainActivityOnBlankPage(); mActivityTestRule.startMainActivityOnBlankPage();
SettingsActivity activity = SettingsActivity activity =
mActivityTestRule.startSettingsActivity(TracingPreferences.class.getName()); mActivityTestRule.startSettingsActivity(TracingSettings.class.getName());
final PreferenceFragmentCompat fragment = final PreferenceFragmentCompat fragment =
(PreferenceFragmentCompat) activity.getMainFragment(); (PreferenceFragmentCompat) activity.getMainFragment();
final Preference defaultCategoriesPref = final Preference defaultCategoriesPref =
fragment.findPreference(TracingPreferences.UI_PREF_DEFAULT_CATEGORIES); fragment.findPreference(TracingSettings.UI_PREF_DEFAULT_CATEGORIES);
final Preference nonDefaultCategoriesPref = final Preference nonDefaultCategoriesPref =
fragment.findPreference(TracingPreferences.UI_PREF_NON_DEFAULT_CATEGORIES); fragment.findPreference(TracingSettings.UI_PREF_NON_DEFAULT_CATEGORIES);
waitForTracingControllerInitialization(fragment); waitForTracingControllerInitialization(fragment);
...@@ -296,29 +296,29 @@ public class TracingPreferencesTest { ...@@ -296,29 +296,29 @@ public class TracingPreferencesTest {
Context context = InstrumentationRegistry.getTargetContext(); Context context = InstrumentationRegistry.getTargetContext();
Assert.assertNotNull(categoriesPref.getExtras()); Assert.assertNotNull(categoriesPref.getExtras());
Assert.assertFalse(categoriesPref.getExtras().isEmpty()); Assert.assertFalse(categoriesPref.getExtras().isEmpty());
Intent intent = PreferencesLauncher.createIntentForSettingsPage(context, Intent intent = PreferencesLauncher.createIntentForSettingsPage(
TracingCategoriesPreferences.class.getName(), categoriesPref.getExtras()); context, TracingCategoriesSettings.class.getName(), categoriesPref.getExtras());
SettingsActivity categoriesActivity = SettingsActivity categoriesActivity =
(SettingsActivity) InstrumentationRegistry.getInstrumentation() (SettingsActivity) InstrumentationRegistry.getInstrumentation()
.startActivitySync(intent); .startActivitySync(intent);
PreferenceFragmentCompat categoriesFragment = PreferenceFragmentCompat categoriesFragment =
(PreferenceFragmentCompat) categoriesActivity.getMainFragment(); (PreferenceFragmentCompat) categoriesActivity.getMainFragment();
Assert.assertEquals(TracingCategoriesPreferences.class, categoriesFragment.getClass()); Assert.assertEquals(TracingCategoriesSettings.class, categoriesFragment.getClass());
CheckBoxPreference sampleCategoryPref = CheckBoxPreference sampleCategoryPref =
(CheckBoxPreference) categoriesFragment.findPreference(sampleCategoryName); (CheckBoxPreference) categoriesFragment.findPreference(sampleCategoryName);
Assert.assertNotNull(sampleCategoryPref); Assert.assertNotNull(sampleCategoryPref);
boolean originallyEnabled = boolean originallyEnabled =
TracingPreferences.getEnabledCategories().contains(sampleCategoryName); TracingSettings.getEnabledCategories().contains(sampleCategoryName);
Assert.assertEquals(originallyEnabled, sampleCategoryPref.isChecked()); Assert.assertEquals(originallyEnabled, sampleCategoryPref.isChecked());
// Simulate selecting / deselecting the category. // Simulate selecting / deselecting the category.
TestThreadUtils.runOnUiThreadBlocking(sampleCategoryPref::performClick); TestThreadUtils.runOnUiThreadBlocking(sampleCategoryPref::performClick);
Assert.assertNotEquals(originallyEnabled, sampleCategoryPref.isChecked()); Assert.assertNotEquals(originallyEnabled, sampleCategoryPref.isChecked());
boolean finallyEnabled = boolean finallyEnabled =
TracingPreferences.getEnabledCategories().contains(sampleCategoryName); TracingSettings.getEnabledCategories().contains(sampleCategoryName);
Assert.assertNotEquals(originallyEnabled, finallyEnabled); Assert.assertNotEquals(originallyEnabled, finallyEnabled);
} }
} }
...@@ -328,11 +328,11 @@ public class TracingPreferencesTest { ...@@ -328,11 +328,11 @@ public class TracingPreferencesTest {
@Feature({"Preferences"}) @Feature({"Preferences"})
public void testSelectMode() throws Exception { public void testSelectMode() throws Exception {
SettingsActivity activity = SettingsActivity activity =
mActivityTestRule.startSettingsActivity(TracingPreferences.class.getName()); mActivityTestRule.startSettingsActivity(TracingSettings.class.getName());
final PreferenceFragmentCompat fragment = final PreferenceFragmentCompat fragment =
(PreferenceFragmentCompat) activity.getMainFragment(); (PreferenceFragmentCompat) activity.getMainFragment();
final ListPreference modePref = final ListPreference modePref =
(ListPreference) fragment.findPreference(TracingPreferences.UI_PREF_MODE); (ListPreference) fragment.findPreference(TracingSettings.UI_PREF_MODE);
waitForTracingControllerInitialization(fragment); waitForTracingControllerInitialization(fragment);
...@@ -340,7 +340,7 @@ public class TracingPreferencesTest { ...@@ -340,7 +340,7 @@ public class TracingPreferencesTest {
Assert.assertTrue(modePref.isEnabled()); Assert.assertTrue(modePref.isEnabled());
// By default, the "record-until-full" mode is selected. // By default, the "record-until-full" mode is selected.
Assert.assertEquals("record-until-full", TracingPreferences.getSelectedTracingMode()); Assert.assertEquals("record-until-full", TracingSettings.getSelectedTracingMode());
// Dialog should contain 3 entries. // Dialog should contain 3 entries.
Assert.assertEquals(3, modePref.getEntries().length); Assert.assertEquals(3, modePref.getEntries().length);
...@@ -348,7 +348,7 @@ public class TracingPreferencesTest { ...@@ -348,7 +348,7 @@ public class TracingPreferencesTest {
// Simulate changing the mode. // Simulate changing the mode.
modePref.getOnPreferenceChangeListener().onPreferenceChange( modePref.getOnPreferenceChangeListener().onPreferenceChange(
modePref, "record-continuously"); modePref, "record-continuously");
Assert.assertEquals("record-continuously", TracingPreferences.getSelectedTracingMode()); Assert.assertEquals("record-continuously", TracingSettings.getSelectedTracingMode());
}); });
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment