Commit 12371733 authored by Caleb Rouleau's avatar Caleb Rouleau Committed by Commit Bot

[telemetry benchmarks wrapper] override test repeat argument if asked to

I checked if you run like this:
./run_benchmark ... --pageset-repeat=3 --pageset-repeat=1
then the second argument overrides the first.

Bug: 894254
Change-Id: Ib7138966dfa5336697a7a5c02084557f315aac4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628161Reviewed-by: default avatarChan Li <chanli@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662906}
parent be7290f2
...@@ -259,12 +259,13 @@ class TelemetryCommandGenerator(object): ...@@ -259,12 +259,13 @@ class TelemetryCommandGenerator(object):
return ([sys.executable, self._options.executable] + return ([sys.executable, self._options.executable] +
[self.benchmark] + [self.benchmark] +
self._generate_filter_args() + self._generate_filter_args() +
self._generate_repeat_args() +
self._generate_also_run_disabled_tests_args() + self._generate_also_run_disabled_tests_args() +
self._generate_output_args(output_dir) + self._generate_output_args(output_dir) +
self._generate_story_range_args() + self._generate_story_range_args() +
# passthrough args must be before reference args: crbug.com/928928 # passthrough args must be before reference args and repeat args:
# crbug.com/928928, crbug.com/894254#c78
self._get_passthrough_args() + self._get_passthrough_args() +
self._generate_repeat_args() +
self._generate_reference_build_args() self._generate_reference_build_args()
) )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment