Commit 126a0e6e authored by Benjamin C. Wiley Sittler's avatar Benjamin C. Wiley Sittler Committed by Commit Bot

Forms: use http: rather than file: to accomodate OOPIF

Bug: 786539
Bug: 661819
Change-Id: I26167fe8cf6f5959420d15fbed9e49a118f445b7
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/778019
Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org>
Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517694}
parent 7b33c549
...@@ -153,18 +153,6 @@ crbug.com/778696 virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-comp ...@@ -153,18 +153,6 @@ crbug.com/778696 virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-comp
# https://crbug.com/778372: Unique name conflict with old entries? # https://crbug.com/778372: Unique name conflict with old entries?
crbug.com/778372 external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [ Crash ] crbug.com/778372 external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [ Crash ]
# https://crbug.com/786539: possible file drag-and-drop issue with OOPIFs?
crbug.com/786539 http/tests/local/fileapi/send-dragged-file-form-iso-2022-jp.html [ Failure ]
crbug.com/786539 http/tests/local/fileapi/send-dragged-file-form-utf-8.html [ Failure ]
crbug.com/786539 http/tests/local/fileapi/send-dragged-file-form-windows-1252.html [ Failure ]
crbug.com/786539 http/tests/local/fileapi/send-dragged-file-form-x-user-defined.html [ Failure ]
crbug.com/786539 http/tests/local/fileapi/send-dragged-file-form.html [ Failure ]
crbug.com/786539 virtual/mojo-loading/http/tests/local/fileapi/send-dragged-file-form-iso-2022-jp.html [ Failure ]
crbug.com/786539 virtual/mojo-loading/http/tests/local/fileapi/send-dragged-file-form-utf-8.html [ Failure ]
crbug.com/786539 virtual/mojo-loading/http/tests/local/fileapi/send-dragged-file-form-windows-1252.html [ Failure ]
crbug.com/786539 virtual/mojo-loading/http/tests/local/fileapi/send-dragged-file-form-x-user-defined.html [ Failure ]
crbug.com/786539 virtual/mojo-loading/http/tests/local/fileapi/send-dragged-file-form.html [ Failure ]
# The tests below are inherently incompatible with isolating same-site, cross-origin # The tests below are inherently incompatible with isolating same-site, cross-origin
# frames into separate processes (which is how Site Isolation bots treat # frames into separate processes (which is how Site Isolation bots treat
# www1.web-platform.test, www2.web-platform.test, etc). # www1.web-platform.test, www2.web-platform.test, etc).
......
...@@ -100,8 +100,8 @@ const kWebServer = 'http://127.0.0.1:8000'; ...@@ -100,8 +100,8 @@ const kWebServer = 'http://127.0.0.1:8000';
// numeric character reference replacement for filenames, field names, // numeric character reference replacement for filenames, field names,
// and field values. // and field values.
// //
// Uses /local/fileapi/resources/write-temp-file.cgi to create the // Uses /fileapi/resources/write-temp-file.cgi to create the
// test file and /local/fileapi/resources/delete-temp-file.cgi to // test file and /fileapi/resources/delete-temp-file.cgi to
// remove it at the end of the test. // remove it at the end of the test.
// //
// Uses /xmlhttprequest/resources/post-echo.cgi to echo the upload // Uses /xmlhttprequest/resources/post-echo.cgi to echo the upload
...@@ -212,7 +212,7 @@ const formPostFileUploadTest = ({ ...@@ -212,7 +212,7 @@ const formPostFileUploadTest = ({
form.appendChild(fileInput); form.appendChild(fileInput);
const fileToDropLines = (await (await fetch( const fileToDropLines = (await (await fetch(
`${kWebServer}/local/fileapi/resources/write-temp-file.cgi` + `${kWebServer}/fileapi/resources/write-temp-file.cgi` +
`?filename=${ `?filename=${
encodeURIComponent(fileBaseName) encodeURIComponent(fileBaseName)
}&data=${encodeURIComponent(kTestChars)}`, }&data=${encodeURIComponent(kTestChars)}`,
...@@ -260,13 +260,13 @@ const formPostFileUploadTest = ({ ...@@ -260,13 +260,13 @@ const formPostFileUploadTest = ({
}); });
} finally { } finally {
const cleanupErrors = await (await fetch( const cleanupErrors = await (await fetch(
`${kWebServer}/local/fileapi/resources/delete-temp-file.cgi` + `${kWebServer}/fileapi/resources/delete-temp-file.cgi` +
`?filename=${encodeURIComponent(fileToDrop)}`, `?filename=${encodeURIComponent(fileToDrop)}`,
{ method: 'post' })).text(); { method: 'post' })).text();
assert_equals(cleanupErrors, 'OK', 'Temp file cleanup should not fail'); assert_equals(cleanupErrors, 'OK', 'Temp file cleanup should not fail');
} }
const formDataText = formTargetFrame.contentDocument.body.innerText; const formDataText = formTargetFrame.contentDocument.body.textContent;
const formDataLines = formDataText.split('\n'); const formDataLines = formDataText.split('\n');
if (formDataLines.length && !formDataLines[formDataLines.length - 1]) { if (formDataLines.length && !formDataLines[formDataLines.length - 1]) {
--formDataLines.length; --formDataLines.length;
......
...@@ -5,8 +5,8 @@ ...@@ -5,8 +5,8 @@
href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data"> href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data">
<link rel="author" title="Benjamin C. Wiley Sittler" <link rel="author" title="Benjamin C. Wiley Sittler"
href="mailto:bsittler@chromium.org"> href="mailto:bsittler@chromium.org">
<script src="../../../../resources/testharness.js"></script> <script src="/resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script> <script src="/resources/testharnessreport.js"></script>
<script src="resources/send-dragged-file-form-helper.js"></script> <script src="resources/send-dragged-file-form-helper.js"></script>
<!-- <!--
......
...@@ -5,8 +5,8 @@ ...@@ -5,8 +5,8 @@
href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data"> href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data">
<link rel="author" title="Benjamin C. Wiley Sittler" <link rel="author" title="Benjamin C. Wiley Sittler"
href="mailto:bsittler@chromium.org"> href="mailto:bsittler@chromium.org">
<script src="../../../../resources/testharness.js"></script> <script src="/resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script> <script src="/resources/testharnessreport.js"></script>
<script src="resources/send-dragged-file-form-helper.js"></script> <script src="resources/send-dragged-file-form-helper.js"></script>
<!-- <!--
......
...@@ -5,8 +5,8 @@ ...@@ -5,8 +5,8 @@
href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data"> href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data">
<link rel="author" title="Benjamin C. Wiley Sittler" <link rel="author" title="Benjamin C. Wiley Sittler"
href="mailto:bsittler@chromium.org"> href="mailto:bsittler@chromium.org">
<script src="../../../../resources/testharness.js"></script> <script src="/resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script> <script src="/resources/testharnessreport.js"></script>
<script src="resources/send-dragged-file-form-helper.js"></script> <script src="resources/send-dragged-file-form-helper.js"></script>
<!-- <!--
......
...@@ -5,8 +5,8 @@ ...@@ -5,8 +5,8 @@
href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data"> href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data">
<link rel="author" title="Benjamin C. Wiley Sittler" <link rel="author" title="Benjamin C. Wiley Sittler"
href="mailto:bsittler@chromium.org"> href="mailto:bsittler@chromium.org">
<script src="../../../../resources/testharness.js"></script> <script src="/resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script> <script src="/resources/testharnessreport.js"></script>
<script src="resources/send-dragged-file-form-helper.js"></script> <script src="resources/send-dragged-file-form-helper.js"></script>
<!-- <!--
......
...@@ -5,8 +5,8 @@ ...@@ -5,8 +5,8 @@
href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data"> href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data">
<link rel="author" title="Benjamin C. Wiley Sittler" <link rel="author" title="Benjamin C. Wiley Sittler"
href="mailto:bsittler@chromium.org"> href="mailto:bsittler@chromium.org">
<script src="../../../../resources/testharness.js"></script> <script src="/resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script> <script src="/resources/testharnessreport.js"></script>
<script src="resources/send-dragged-file-form-helper.js"></script> <script src="resources/send-dragged-file-form-helper.js"></script>
<script> <script>
'use strict'; 'use strict';
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment