Commit 12814abd authored by Boris Sazonov's avatar Boris Sazonov Committed by Commit Bot

[Signin][Android] Enable MobileIdentityConsistency in testing config

Adds MobileIdentityConsistency to
testing/variations/fieldtrial_testing_config.json and adds explicit
@DisableFeatures to the affected tests.

Bug: 1128916, 1142467
Change-Id: I25afb6de05d2ce232f1006a8497884f9db18d52e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489895
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820973}
parent c9693c9a
...@@ -150,6 +150,7 @@ public class NewTabPageTest { ...@@ -150,6 +150,7 @@ public class NewTabPageTest {
@Test @Test
@MediumTest @MediumTest
@Feature({"NewTabPage", "FeedNewTabPage", "RenderTest"}) @Feature({"NewTabPage", "FeedNewTabPage", "RenderTest"})
@Features.DisableFeatures(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
public void testRender_FocusFakeBox() throws Exception { public void testRender_FocusFakeBox() throws Exception {
ScrimCoordinator scrimCoordinator = mActivityTestRule.getActivity() ScrimCoordinator scrimCoordinator = mActivityTestRule.getActivity()
.getRootUiCoordinatorForTesting() .getRootUiCoordinatorForTesting()
...@@ -164,6 +165,7 @@ public class NewTabPageTest { ...@@ -164,6 +165,7 @@ public class NewTabPageTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"NewTabPage", "FeedNewTabPage", "RenderTest"}) @Feature({"NewTabPage", "FeedNewTabPage", "RenderTest"})
@Features.DisableFeatures(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
public void testRender_SignInPromo() throws Exception { public void testRender_SignInPromo() throws Exception {
// Scroll to the sign in promo in case it is not visible. // Scroll to the sign in promo in case it is not visible.
onView(instanceOf(RecyclerView.class)) onView(instanceOf(RecyclerView.class))
......
...@@ -99,6 +99,7 @@ public class RecentTabsPageTest { ...@@ -99,6 +99,7 @@ public class RecentTabsPageTest {
@Test @Test
@LargeTest @LargeTest
@Feature("RenderTest") @Feature("RenderTest")
@Features.DisableFeatures({ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY})
public void testPersonalizedSigninPromoInRecentTabsPage() throws Exception { public void testPersonalizedSigninPromoInRecentTabsPage() throws Exception {
mAccountManagerTestRule.addAccount(mAccountManagerTestRule.createProfileDataFromName( mAccountManagerTestRule.addAccount(mAccountManagerTestRule.createProfileDataFromName(
AccountManagerTestRule.TEST_ACCOUNT_EMAIL)); AccountManagerTestRule.TEST_ACCOUNT_EMAIL));
......
...@@ -165,8 +165,10 @@ public class MainSettingsFragmentTest { ...@@ -165,8 +165,10 @@ public class MainSettingsFragmentTest {
@LargeTest @LargeTest
@Feature({"RenderTest"}) @Feature({"RenderTest"})
@EnableFeatures({ChromeFeatureList.SAFE_BROWSING_SECTION_UI}) @EnableFeatures({ChromeFeatureList.SAFE_BROWSING_SECTION_UI})
@DisableFeatures({ChromeFeatureList.SAFETY_CHECK_ANDROID}) @DisableFeatures(
public void testRenderDifferentSignedInStates() throws IOException { {ChromeFeatureList.SAFETY_CHECK_ANDROID, ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY})
public void
testRenderDifferentSignedInStates() throws IOException {
launchSettingsActivity(); launchSettingsActivity();
View view = mSettingsActivityTestRule.getActivity() View view = mSettingsActivityTestRule.getActivity()
.findViewById(android.R.id.content) .findViewById(android.R.id.content)
...@@ -184,6 +186,7 @@ public class MainSettingsFragmentTest { ...@@ -184,6 +186,7 @@ public class MainSettingsFragmentTest {
@Feature({"RenderTest"}) @Feature({"RenderTest"})
@EnableFeatures( @EnableFeatures(
{ChromeFeatureList.SAFETY_CHECK_ANDROID, ChromeFeatureList.SAFE_BROWSING_SECTION_UI}) {ChromeFeatureList.SAFETY_CHECK_ANDROID, ChromeFeatureList.SAFE_BROWSING_SECTION_UI})
@DisableFeatures(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
public void public void
testRenderDifferentSignedInStatesWithSafetyCheck() throws IOException { testRenderDifferentSignedInStatesWithSafetyCheck() throws IOException {
launchSettingsActivity(); launchSettingsActivity();
...@@ -207,6 +210,7 @@ public class MainSettingsFragmentTest { ...@@ -207,6 +210,7 @@ public class MainSettingsFragmentTest {
@Test @Test
@SmallTest @SmallTest
@EnableFeatures({ChromeFeatureList.PASSWORD_CHECK, ChromeFeatureList.SAFETY_CHECK_ANDROID}) @EnableFeatures({ChromeFeatureList.PASSWORD_CHECK, ChromeFeatureList.SAFETY_CHECK_ANDROID})
@DisableFeatures(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
public void testStartup() { public void testStartup() {
launchSettingsActivity(); launchSettingsActivity();
...@@ -367,6 +371,7 @@ public class MainSettingsFragmentTest { ...@@ -367,6 +371,7 @@ public class MainSettingsFragmentTest {
*/ */
@Test @Test
@SmallTest @SmallTest
@DisableFeatures({ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY})
public void testAccountSignIn() { public void testAccountSignIn() {
launchSettingsActivity(); launchSettingsActivity();
......
...@@ -4372,6 +4372,21 @@ ...@@ -4372,6 +4372,21 @@
] ]
} }
], ],
"MobileIdentityConsistency": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"MobileIdentityConsistency"
]
}
]
}
],
"MyChromeEverywhere": [ "MyChromeEverywhere": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment