Commit 1285eaac authored by Jan Krcal's avatar Jan Krcal Committed by Commit Bot

[Autofill sync] Add logging info to debug flaky integration tests

This CL adds a few debug lines to investigate flakiness. There's no
behavioral change and the commit will get reverted once the
investigation is over.

Bug: 997629
Change-Id: I55a19c467affdaed1ed62ea8fb2545dc570b2877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026734
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: default avatarMaxim Kolosovskiy <kolos@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737264}
parent 4c22539f
...@@ -292,6 +292,9 @@ void SetProfiles(int profile, std::vector<AutofillProfile>* autofill_profiles) { ...@@ -292,6 +292,9 @@ void SetProfiles(int profile, std::vector<AutofillProfile>* autofill_profiles) {
EXPECT_CALL(personal_data_observer, OnPersonalDataChanged()) EXPECT_CALL(personal_data_observer, OnPersonalDataChanged())
.Times(testing::AnyNumber()); .Times(testing::AnyNumber());
// TODO(crbug.com/997629): Remove after investigation is over.
DLOG(WARNING) << "SetProfiles " << autofill_profiles->size();
pdm->SetProfiles(autofill_profiles); pdm->SetProfiles(autofill_profiles);
run_loop.Run(); run_loop.Run();
......
...@@ -1502,10 +1502,16 @@ void PersonalDataManager::DedupeCreditCardToSuggest( ...@@ -1502,10 +1502,16 @@ void PersonalDataManager::DedupeCreditCardToSuggest(
} }
void PersonalDataManager::SetProfiles(std::vector<AutofillProfile>* profiles) { void PersonalDataManager::SetProfiles(std::vector<AutofillProfile>* profiles) {
if (is_off_the_record_) if (is_off_the_record_) {
// TODO(crbug.com/997629): Remove after investigation is over.
DLOG(WARNING) << "Cannot SetProfiles because off-the-record";
return; return;
if (!database_helper_->GetLocalDatabase()) }
if (!database_helper_->GetLocalDatabase()) {
// TODO(crbug.com/997629): Remove after investigation is over.
DLOG(WARNING) << "Cannot SetProfiles because no local DB";
return; return;
}
ClearOnGoingProfileChanges(); ClearOnGoingProfileChanges();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment