Migrate off BrowserThread::DeleteSoon in /fuchsia

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=kmarshall@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I9d65b702148140bab94514de52e0a551f4cb9d63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895647
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712395}

fuchsia/engine/browser/frame_impl.cc

@@ -281,8 +281,8 @@ void FrameImpl::TearDownView() {
 
     // Allows posted focus events to process before the FocusController is torn
     // down.
-    content::BrowserThread::DeleteSoon(content::BrowserThread::UI, FROM_HERE,
-                                       std::move(focus_controller_));
+    base::DeleteSoon(FROM_HERE, {content::BrowserThread::UI},
+                     std::move(focus_controller_));
   }
 }
 

fuchsia/engine/browser/web_engine_browser_context.cc

@@ -65,8 +65,8 @@ WebEngineBrowserContext::~WebEngineBrowserContext() {
   NotifyWillBeDestroyed(this);
 
   if (resource_context_) {
-    content::BrowserThread::DeleteSoon(content::BrowserThread::IO, FROM_HERE,
-                                       std::move(resource_context_));
+    base::DeleteSoon(FROM_HERE, {content::BrowserThread::IO},
+                     std::move(resource_context_));
   }
 
   ShutdownStoragePartitions();