Commit 1299d0c9 authored by ericrk's avatar ericrk Committed by Commit bot

Remove warning DCHECK from GPU Image Decode Controller

When uploading an image, the DeferredTextureImageUsageParams should not
have changed from initial sizing time. Somehow this can happen. This is
not a correctness error, but a slight perf issue, as it will cause us
to lazy generate mips as opposed to doing so asynchronously.

We should fix this issue and re-add the DCHECKs to enforce this, but
until we are able to, remove the DCHECK.

BUG=649167
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2361493005
Cr-Commit-Position: refs/heads/master@{#420685}
parent 8768302e
......@@ -973,12 +973,9 @@ void GpuImageDecodeController::DecodeImageIfNecessary(
break;
}
case DecodedDataMode::GPU: {
// Params should not have changed since initial sizing.
DCHECK(image_data->upload_params.fMatrix == draw_image.matrix());
DCHECK_EQ(image_data->upload_params.fPreScaleMipLevel,
CalculateUploadScaleMipLevel(draw_image));
DCHECK_EQ(image_data->upload_params.fQuality,
CalculateUploadScaleFilterQuality(draw_image));
// TODO(crbug.com/649167): Params should not have changed since initial
// sizing. Somehow this still happens. We should investigate and re-add
// DCHECKs here to enforce this.
if (!draw_image.image()->getDeferredTextureImageData(
*context_threadsafe_proxy_.get(), &image_data->upload_params, 1,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment