Commit 129c180f authored by Minoru Chikamune's avatar Minoru Chikamune Committed by Commit Bot

[HeapMojo] Fix WebSettingsTest#testAccessCacheMode failure on Android L and M

Still not sure the root cause, but WebSettingsTest#testAccessCacheMode is failing on Android L and M. And this failure is caused by HeapMojoReceiver for ImageDownloaderImpl.receiver_.

This CL specifies HeapMojoWrapperMode::kForceWithoutContextObserver not to close connection when the associated ExecutionContext is detached.

Bug: 1102041, 1049056
Change-Id: I4a88ec57f2b04671a2d7ffad953600713442f648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395195Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804666}
parent 5e6bf38c
...@@ -94,7 +94,7 @@ class ImageDownloaderImpl final : public GarbageCollected<ImageDownloaderImpl>, ...@@ -94,7 +94,7 @@ class ImageDownloaderImpl final : public GarbageCollected<ImageDownloaderImpl>,
HeapMojoReceiver<mojom::blink::ImageDownloader, HeapMojoReceiver<mojom::blink::ImageDownloader,
ImageDownloaderImpl, ImageDownloaderImpl,
HeapMojoWrapperMode::kWithoutContextObserver> HeapMojoWrapperMode::kForceWithoutContextObserver>
receiver_; receiver_;
DISALLOW_COPY_AND_ASSIGN(ImageDownloaderImpl); DISALLOW_COPY_AND_ASSIGN(ImageDownloaderImpl);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment