Commit 12be1b71 authored by Alexandre Courbot's avatar Alexandre Courbot Committed by Commit Bot

media/gpu/v4l2ip: remove faulty DCHECK()

This DCHECK is faulty is several accounts:

* It makes the program fault depending on the value of an argument,
* The values it checks are actually valid to the ioctl,

Finally, it has not been tested in debug mode since direct callers
of the method in the same file use the values that trigger it as
parameter.

BUG=1033799
TEST=vdatest passes on Hana.

Change-Id: Ic23f4baf94c89dceb9aeb4881a4b4942e1bebf9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130460
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: default avatarHirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755240}
parent f2c72f4e
...@@ -598,7 +598,6 @@ void V4L2ImageProcessorBackend::Reset() { ...@@ -598,7 +598,6 @@ void V4L2ImageProcessorBackend::Reset() {
bool V4L2ImageProcessorBackend::ApplyCrop(const gfx::Rect& visible_rect, bool V4L2ImageProcessorBackend::ApplyCrop(const gfx::Rect& visible_rect,
enum v4l2_buf_type type) { enum v4l2_buf_type type) {
DCHECK(V4L2_TYPE_IS_MULTIPLANAR(type));
struct v4l2_rect rect {}; struct v4l2_rect rect {};
rect.left = visible_rect.x(); rect.left = visible_rect.x();
rect.top = visible_rect.y(); rect.top = visible_rect.y();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment