Commit 12cb5600 authored by David Roger's avatar David Roger Committed by Commit Bot

Disable flaky InstallServiceWorkItemTests

TBR=ganesh

Bug: 1055470
Change-Id: Iece9e9d0f62739ead1c32b529b0bf2f80761e7aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080356Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745431}
parent d027bf21
...@@ -64,7 +64,8 @@ TEST_F(InstallServiceWorkItemTest, Do_MultiSzToVector) { ...@@ -64,7 +64,8 @@ TEST_F(InstallServiceWorkItemTest, Do_MultiSzToVector) {
EXPECT_EQ(vec.size(), base::size(kMultiSz)); EXPECT_EQ(vec.size(), base::size(kMultiSz));
} }
TEST_F(InstallServiceWorkItemTest, Do_FreshInstall) { // This test is flaky, see https://crbug.com/1055470
TEST_F(InstallServiceWorkItemTest, DISABLED_Do_FreshInstall) {
auto item = std::make_unique<InstallServiceWorkItem>( auto item = std::make_unique<InstallServiceWorkItem>(
kServiceName, kServiceDisplayName, kServiceName, kServiceDisplayName,
base::CommandLine(base::FilePath(kServiceProgramPath))); base::CommandLine(base::FilePath(kServiceProgramPath)));
...@@ -77,7 +78,8 @@ TEST_F(InstallServiceWorkItemTest, Do_FreshInstall) { ...@@ -77,7 +78,8 @@ TEST_F(InstallServiceWorkItemTest, Do_FreshInstall) {
EXPECT_FALSE(GetImpl(item.get())->OpenService()); EXPECT_FALSE(GetImpl(item.get())->OpenService());
} }
TEST_F(InstallServiceWorkItemTest, Do_FreshInstallThenDeleteService) { // This test is flaky, see https://crbug.com/1055470
TEST_F(InstallServiceWorkItemTest, DISABLED_Do_FreshInstallThenDeleteService) {
auto item = std::make_unique<InstallServiceWorkItem>( auto item = std::make_unique<InstallServiceWorkItem>(
kServiceName, kServiceDisplayName, kServiceName, kServiceDisplayName,
base::CommandLine(base::FilePath(kServiceProgramPath))); base::CommandLine(base::FilePath(kServiceProgramPath)));
...@@ -89,7 +91,8 @@ TEST_F(InstallServiceWorkItemTest, Do_FreshInstallThenDeleteService) { ...@@ -89,7 +91,8 @@ TEST_F(InstallServiceWorkItemTest, Do_FreshInstallThenDeleteService) {
EXPECT_TRUE(InstallServiceWorkItem::DeleteService(kServiceName)); EXPECT_TRUE(InstallServiceWorkItem::DeleteService(kServiceName));
} }
TEST_F(InstallServiceWorkItemTest, Do_UpgradeNoChanges) { // This test is flaky, see https://crbug.com/1055470
TEST_F(InstallServiceWorkItemTest, DISABLED_Do_UpgradeNoChanges) {
auto item = std::make_unique<InstallServiceWorkItem>( auto item = std::make_unique<InstallServiceWorkItem>(
kServiceName, kServiceDisplayName, kServiceName, kServiceDisplayName,
base::CommandLine(base::FilePath(kServiceProgramPath))); base::CommandLine(base::FilePath(kServiceProgramPath)));
...@@ -109,7 +112,8 @@ TEST_F(InstallServiceWorkItemTest, Do_UpgradeNoChanges) { ...@@ -109,7 +112,8 @@ TEST_F(InstallServiceWorkItemTest, Do_UpgradeNoChanges) {
EXPECT_TRUE(GetImpl(item_upgrade.get())->DeleteCurrentService()); EXPECT_TRUE(GetImpl(item_upgrade.get())->DeleteCurrentService());
} }
TEST_F(InstallServiceWorkItemTest, Do_UpgradeChangedCmdLine) { // This test is flaky, see https://crbug.com/1055470
TEST_F(InstallServiceWorkItemTest, DISABLED_Do_UpgradeChangedCmdLine) {
auto item = std::make_unique<InstallServiceWorkItem>( auto item = std::make_unique<InstallServiceWorkItem>(
kServiceName, kServiceDisplayName, kServiceName, kServiceDisplayName,
base::CommandLine(base::FilePath(kServiceProgramPath))); base::CommandLine(base::FilePath(kServiceProgramPath)));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment