Make ContentHash::has_verifier_contents private

Whether we have loaded or not valid verified_contents.json is an
internal detail of ContentHash class, which doesn't need to be exposed
to clients.

The only external usage of this is passing it to
ContentVerifier::TestObserver. But TestObserver and its implementations
never used this flag since TestObserver introducing in
https://codereview.chromium.org/1250473002. Therefore it is possible and
makes sense to change it to overall success flag.

Bug: 796395
Change-Id: Ibd48b998a4c42d68e30549a4078184179f5593e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810358Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701967}

extensions/browser/content_verifier.cc

@@ -588,7 +588,7 @@ void ContentVerifier::OnFetchComplete(
   ExtensionId extension_id = content_hash->extension_id();
   if (g_content_verifier_test_observer) {
     g_content_verifier_test_observer->OnFetchComplete(
-        extension_id, content_hash->has_verified_contents());
+        extension_id, content_hash->succeeded());
   }
 
   VLOG(1) << "OnFetchComplete " << extension_id

extensions/browser/content_verifier/content_hash.h

@@ -120,10 +120,6 @@ class ContentHash : public base::RefCountedThreadSafe<ContentHash> {
 
   const ComputedHashes::Reader& computed_hashes() const;
 
-  bool has_verified_contents() const {
-    return status_ >= Status::kHasVerifiedContents;
-  }
-
   bool succeeded() const { return status_ >= Status::kSucceeded; }
 
   // If ContentHash creation writes computed_hashes.json, then this returns the
@@ -195,6 +191,10 @@ class ContentHash : public base::RefCountedThreadSafe<ContentHash> {
                            bool force_build,
                            const IsCancelledCallback& is_cancelled);
 
+  bool has_verified_contents() const {
+    return status_ >= Status::kHasVerifiedContents;
+  }
+
   const ExtensionId extension_id_;
   const base::FilePath extension_root_;