Commit 132ebcfe authored by qi1988.yang's avatar qi1988.yang Committed by Commit Bot

Username are truncated and can't copied fully

For long username, it will be truncated but can't be copied.
Use <input> instead of <div> to make it can be copied easily.

Bug:
Signed-off-by: default avatarqi1988.yang <qi1988.yang@samsung.com>
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3e7826db375ba8120d1828154b2f9bee276e8492
Reviewed-on: https://chromium-review.googlesource.com/973321Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545677}
parent 0e730cbd
...@@ -43,8 +43,8 @@ ...@@ -43,8 +43,8 @@
</span> </span>
</a> </a>
</div> </div>
<div class="username-column text-elide" <input id="username" class="username-column text-elide password-field"
id="username">[[item.entry.loginPair.username]]</div> readonly value="[[item.entry.loginPair.username]]">
<div class="password-column"> <div class="password-column">
<template is="dom-if" if="[[!item.entry.federationText]]"> <template is="dom-if" if="[[!item.entry.federationText]]">
<input id="password" aria-label=$i18n{editPasswordPasswordLabel} <input id="password" aria-label=$i18n{editPasswordPasswordLabel}
......
...@@ -69,7 +69,7 @@ TEST_F('SettingsPasswordSectionBrowserTest', 'uiTests', function() { ...@@ -69,7 +69,7 @@ TEST_F('SettingsPasswordSectionBrowserTest', 'uiTests', function() {
node.$$('#originUrl').href); node.$$('#originUrl').href);
assertEquals( assertEquals(
passwordInfo.loginPair.username, passwordInfo.loginPair.username,
node.$$('#username').textContent.trim()); node.$$('#username').value);
assertEquals(passwordInfo.numCharactersInPassword, assertEquals(passwordInfo.numCharactersInPassword,
node.$$('#password').value.length); node.$$('#password').value.length);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment