Commit 13376e73 authored by Vikas Soni's avatar Vikas Soni Committed by Commit Bot

Fix an invalid DCHECK in SharedImageVideo.

A DCHECK became invalid after a recent refactoring. Move the DCHECK to
more appropriate place.
BeginReadAccess() could be called multiple times on a single shared
image in which case this DCHECK is valid only for the first call. once
|promise_texture_| is created and cached, this DCHECK becomes invalid.

Change-Id: Ia77759ca7797675adbcf41a78c1086e3aebba2a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822318Reviewed-by: default avatarEric Karl <ericrk@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699903}
parent 9c3e8d81
...@@ -329,8 +329,8 @@ class SharedImageRepresentationVideoSkiaVk ...@@ -329,8 +329,8 @@ class SharedImageRepresentationVideoSkiaVk
LOG(ERROR) << "Failed to get the hardware buffer."; LOG(ERROR) << "Failed to get the hardware buffer.";
return nullptr; return nullptr;
} }
DCHECK(scoped_hardware_buffer_->buffer());
} }
DCHECK(scoped_hardware_buffer_->buffer());
// Wait on the sync fd attached to the buffer to make sure buffer is // Wait on the sync fd attached to the buffer to make sure buffer is
// ready before the read. This is done by inserting the sync fd semaphore // ready before the read. This is done by inserting the sync fd semaphore
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment