Clean-up inline members of nested classes (content/)

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10825274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150864 0039d316-1c4b-4281-b951-d872f2087c98

content/common/resource_dispatcher.cc

@@ -531,6 +531,25 @@ void ResourceDispatcher::SetDefersLoading(int request_id, bool value) {
   }
 }
 
+ResourceDispatcher::PendingRequestInfo::PendingRequestInfo()
+    : peer(NULL),
+      resource_type(ResourceType::SUB_RESOURCE),
+      is_deferred(false) {
+}
+
+ResourceDispatcher::PendingRequestInfo::PendingRequestInfo(
+    webkit_glue::ResourceLoaderBridge::Peer* peer,
+    ResourceType::Type resource_type,
+    const GURL& request_url)
+    : peer(peer),
+      resource_type(resource_type),
+      is_deferred(false),
+      url(request_url),
+      request_start(base::TimeTicks::Now()) {
+}
+
+ResourceDispatcher::PendingRequestInfo::~PendingRequestInfo() {}
+
 void ResourceDispatcher::DispatchMessage(const IPC::Message& message) {
   IPC_BEGIN_MESSAGE_MAP(ResourceDispatcher, message)
     IPC_MESSAGE_HANDLER(ResourceMsg_UploadProgress, OnUploadProgress)

content/common/resource_dispatcher.h

@@ -72,23 +72,13 @@ class CONTENT_EXPORT ResourceDispatcher : public IPC::Listener {
 
   typedef std::deque<IPC::Message*> MessageQueue;
   struct PendingRequestInfo {
-    PendingRequestInfo()
-        : peer(NULL),
-          resource_type(ResourceType::SUB_RESOURCE),
-          is_deferred(false) {
-    }
+    PendingRequestInfo();
 
     PendingRequestInfo(webkit_glue::ResourceLoaderBridge::Peer* peer,
                        ResourceType::Type resource_type,
-                       const GURL& request_url)
-        : peer(peer),
-          resource_type(resource_type),
-          is_deferred(false),
-          url(request_url),
-          request_start(base::TimeTicks::Now()) {
-    }
-
-    ~PendingRequestInfo() {}
+                       const GURL& request_url);
+
+    ~PendingRequestInfo();
 
     webkit_glue::ResourceLoaderBridge::Peer* peer;
     ResourceType::Type resource_type;

content/renderer/renderer_accessibility_complete.cc

@@ -222,6 +222,10 @@ void RendererAccessibilityComplete::HandleAccessibilityNotification(
   }
 }
 
+RendererAccessibilityComplete::BrowserTreeNode::BrowserTreeNode() : id(0) {}
+
+RendererAccessibilityComplete::BrowserTreeNode::~BrowserTreeNode() {}
+
 void RendererAccessibilityComplete::SendPendingAccessibilityNotifications() {
   const WebDocument& document = GetMainDocument();
   if (document.isNull())

content/renderer/renderer_accessibility_complete.h

@@ -57,8 +57,8 @@ class RendererAccessibilityComplete : public RendererAccessibility {
   // representation of the browser tree - just IDs and parent/child
   // relationships.
   struct BrowserTreeNode {
-    BrowserTreeNode() : id(0) {}
-    ~BrowserTreeNode() {}
+    BrowserTreeNode();
+    ~BrowserTreeNode();
     int32 id;
     std::vector<BrowserTreeNode*> children;
   };