Commit 138e51aa authored by Jan Wilken Dörrie's avatar Jan Wilken Dörrie Committed by Commit Bot

[base] Apply BindOnceRewriter in //ui

This change applies the BindOnceRewriter in //ui.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=sadrul@chromium.org

Bug: 714018
Change-Id: I741a996064d7932749e6970992b333d0ae94cb5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132214Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760407}
parent ba579425
...@@ -10,6 +10,5 @@ int main(int argc, char* argv[]) { ...@@ -10,6 +10,5 @@ int main(int argc, char* argv[]) {
base::TestSuite test_suite(argc, argv); base::TestSuite test_suite(argc, argv);
return base::LaunchUnitTests( return base::LaunchUnitTests(
argc, argv, argc, argv,
base::BindRepeating(&base::TestSuite::Run, base::BindOnce(&base::TestSuite::Run, base::Unretained(&test_suite)));
base::Unretained(&test_suite)));
} }
\ No newline at end of file
...@@ -50,8 +50,8 @@ class TestPlatformDelegate : public ui::PlatformWindowDelegate { ...@@ -50,8 +50,8 @@ class TestPlatformDelegate : public ui::PlatformWindowDelegate {
void RunPendingTasks(scoped_refptr<base::TaskRunner> task_runner) { void RunPendingTasks(scoped_refptr<base::TaskRunner> task_runner) {
base::WaitableEvent done(base::WaitableEvent::ResetPolicy::AUTOMATIC, base::WaitableEvent done(base::WaitableEvent::ResetPolicy::AUTOMATIC,
base::WaitableEvent::InitialState::NOT_SIGNALED); base::WaitableEvent::InitialState::NOT_SIGNALED);
task_runner->PostTask(FROM_HERE, task_runner->PostTask(
Bind(&base::WaitableEvent::Signal, Unretained(&done))); FROM_HERE, BindOnce(&base::WaitableEvent::Signal, Unretained(&done)));
done.Wait(); done.Wait();
} }
......
...@@ -111,13 +111,13 @@ void SkiaGlRenderer::RenderFrame() { ...@@ -111,13 +111,13 @@ void SkiaGlRenderer::RenderFrame() {
if (gl_surface_->SupportsAsyncSwap()) { if (gl_surface_->SupportsAsyncSwap()) {
gl_surface_->SwapBuffersAsync( gl_surface_->SwapBuffersAsync(
base::BindRepeating(&SkiaGlRenderer::PostRenderFrameTask, base::BindOnce(&SkiaGlRenderer::PostRenderFrameTask,
weak_ptr_factory_.GetWeakPtr()), weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&SkiaGlRenderer::OnPresentation, base::BindOnce(&SkiaGlRenderer::OnPresentation,
weak_ptr_factory_.GetWeakPtr())); weak_ptr_factory_.GetWeakPtr()));
} else { } else {
PostRenderFrameTask( PostRenderFrameTask(
gl_surface_->SwapBuffers(base::BindRepeating( gl_surface_->SwapBuffers(base::BindOnce(
&SkiaGlRenderer::OnPresentation, weak_ptr_factory_.GetWeakPtr())), &SkiaGlRenderer::OnPresentation, weak_ptr_factory_.GetWeakPtr())),
nullptr); nullptr);
} }
...@@ -130,7 +130,7 @@ void SkiaGlRenderer::PostRenderFrameTask( ...@@ -130,7 +130,7 @@ void SkiaGlRenderer::PostRenderFrameTask(
gpu_fence->Wait(); gpu_fence->Wait();
base::ThreadTaskRunnerHandle::Get()->PostTask( base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindRepeating(&SkiaGlRenderer::RenderFrame, FROM_HERE, base::BindOnce(&SkiaGlRenderer::RenderFrame,
weak_ptr_factory_.GetWeakPtr())); weak_ptr_factory_.GetWeakPtr()));
} }
......
...@@ -264,7 +264,7 @@ void SurfacelessSkiaGlRenderer::RenderFrame() { ...@@ -264,7 +264,7 @@ void SurfacelessSkiaGlRenderer::RenderFrame() {
back_buffer_ ^= 1; back_buffer_ ^= 1;
gl_surface_->SwapBuffersAsync( gl_surface_->SwapBuffersAsync(
base::BindRepeating(&SurfacelessSkiaGlRenderer::PostRenderFrameTask, base::BindOnce(&SurfacelessSkiaGlRenderer::PostRenderFrameTask,
weak_ptr_factory_.GetWeakPtr()), weak_ptr_factory_.GetWeakPtr()),
base::DoNothing()); base::DoNothing());
} }
......
...@@ -89,7 +89,7 @@ void WindowManager::OnDisplaysAquired( ...@@ -89,7 +89,7 @@ void WindowManager::OnDisplaysAquired(
delegate_->Configure( delegate_->Configure(
*display, display->native_mode(), origin, *display, display->native_mode(), origin,
base::BindRepeating(&WindowManager::OnDisplayConfigured, base::BindOnce(&WindowManager::OnDisplayConfigured,
base::Unretained(this), base::Unretained(this),
gfx::Rect(origin, display->native_mode()->size()))); gfx::Rect(origin, display->native_mode()->size())));
origin.Offset(display->native_mode()->size().width(), 0); origin.Offset(display->native_mode()->size().width(), 0);
...@@ -99,7 +99,7 @@ void WindowManager::OnDisplaysAquired( ...@@ -99,7 +99,7 @@ void WindowManager::OnDisplaysAquired(
if (should_configure_) { if (should_configure_) {
should_configure_ = false; should_configure_ = false;
base::ThreadTaskRunnerHandle::Get()->PostTask( base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindRepeating(&WindowManager::OnConfigurationChanged, FROM_HERE, base::BindOnce(&WindowManager::OnConfigurationChanged,
base::Unretained(this))); base::Unretained(this)));
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment