Commit 138e51aa authored by Jan Wilken Dörrie's avatar Jan Wilken Dörrie Committed by Commit Bot

[base] Apply BindOnceRewriter in //ui

This change applies the BindOnceRewriter in //ui.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=sadrul@chromium.org

Bug: 714018
Change-Id: I741a996064d7932749e6970992b333d0ae94cb5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132214Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760407}
parent ba579425
......@@ -10,6 +10,5 @@ int main(int argc, char* argv[]) {
base::TestSuite test_suite(argc, argv);
return base::LaunchUnitTests(
argc, argv,
base::BindRepeating(&base::TestSuite::Run,
base::Unretained(&test_suite)));
base::BindOnce(&base::TestSuite::Run, base::Unretained(&test_suite)));
}
\ No newline at end of file
......@@ -50,8 +50,8 @@ class TestPlatformDelegate : public ui::PlatformWindowDelegate {
void RunPendingTasks(scoped_refptr<base::TaskRunner> task_runner) {
base::WaitableEvent done(base::WaitableEvent::ResetPolicy::AUTOMATIC,
base::WaitableEvent::InitialState::NOT_SIGNALED);
task_runner->PostTask(FROM_HERE,
Bind(&base::WaitableEvent::Signal, Unretained(&done)));
task_runner->PostTask(
FROM_HERE, BindOnce(&base::WaitableEvent::Signal, Unretained(&done)));
done.Wait();
}
......
......@@ -111,13 +111,13 @@ void SkiaGlRenderer::RenderFrame() {
if (gl_surface_->SupportsAsyncSwap()) {
gl_surface_->SwapBuffersAsync(
base::BindRepeating(&SkiaGlRenderer::PostRenderFrameTask,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&SkiaGlRenderer::OnPresentation,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&SkiaGlRenderer::PostRenderFrameTask,
weak_ptr_factory_.GetWeakPtr()),
base::BindOnce(&SkiaGlRenderer::OnPresentation,
weak_ptr_factory_.GetWeakPtr()));
} else {
PostRenderFrameTask(
gl_surface_->SwapBuffers(base::BindRepeating(
gl_surface_->SwapBuffers(base::BindOnce(
&SkiaGlRenderer::OnPresentation, weak_ptr_factory_.GetWeakPtr())),
nullptr);
}
......@@ -130,8 +130,8 @@ void SkiaGlRenderer::PostRenderFrameTask(
gpu_fence->Wait();
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindRepeating(&SkiaGlRenderer::RenderFrame,
weak_ptr_factory_.GetWeakPtr()));
FROM_HERE, base::BindOnce(&SkiaGlRenderer::RenderFrame,
weak_ptr_factory_.GetWeakPtr()));
}
void SkiaGlRenderer::Draw(SkCanvas* canvas, float fraction) {
......
......@@ -264,8 +264,8 @@ void SurfacelessSkiaGlRenderer::RenderFrame() {
back_buffer_ ^= 1;
gl_surface_->SwapBuffersAsync(
base::BindRepeating(&SurfacelessSkiaGlRenderer::PostRenderFrameTask,
weak_ptr_factory_.GetWeakPtr()),
base::BindOnce(&SurfacelessSkiaGlRenderer::PostRenderFrameTask,
weak_ptr_factory_.GetWeakPtr()),
base::DoNothing());
}
......
......@@ -89,9 +89,9 @@ void WindowManager::OnDisplaysAquired(
delegate_->Configure(
*display, display->native_mode(), origin,
base::BindRepeating(&WindowManager::OnDisplayConfigured,
base::Unretained(this),
gfx::Rect(origin, display->native_mode()->size())));
base::BindOnce(&WindowManager::OnDisplayConfigured,
base::Unretained(this),
gfx::Rect(origin, display->native_mode()->size())));
origin.Offset(display->native_mode()->size().width(), 0);
}
is_configuring_ = false;
......@@ -99,8 +99,8 @@ void WindowManager::OnDisplaysAquired(
if (should_configure_) {
should_configure_ = false;
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindRepeating(&WindowManager::OnConfigurationChanged,
base::Unretained(this)));
FROM_HERE, base::BindOnce(&WindowManager::OnConfigurationChanged,
base::Unretained(this)));
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment