Commit 13ac0533 authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

Migrate ScriptFunction to NewScriptFunction in core/testing/internals.cc

Bug: 1152249
Change-Id: Id21f5ec3531f3b3b03f163fe3d1f8d848ca3b8fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556887
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830500}
parent 4517f6db
...@@ -3005,25 +3005,16 @@ void Internals::setShouldRevealPassword(Element* element, ...@@ -3005,25 +3005,16 @@ void Internals::setShouldRevealPassword(Element* element,
namespace { namespace {
class AddOneFunction : public ScriptFunction { class AddOneFunction : public NewScriptFunction::Callable {
public: public:
static v8::Local<v8::Function> CreateFunction(ScriptState* script_state) { ScriptValue Call(ScriptState* script_state, ScriptValue value) override {
AddOneFunction* self = MakeGarbageCollected<AddOneFunction>(script_state);
return self->BindToV8Function();
}
explicit AddOneFunction(ScriptState* script_state)
: ScriptFunction(script_state) {}
private:
ScriptValue Call(ScriptValue value) override {
v8::Local<v8::Value> v8_value = value.V8Value(); v8::Local<v8::Value> v8_value = value.V8Value();
DCHECK(v8_value->IsNumber()); DCHECK(v8_value->IsNumber());
int32_t int_value = int32_t int_value =
static_cast<int32_t>(v8_value.As<v8::Integer>()->Value()); static_cast<int32_t>(v8_value.As<v8::Integer>()->Value());
return ScriptValue( return ScriptValue(
GetScriptState()->GetIsolate(), script_state->GetIsolate(),
v8::Integer::New(GetScriptState()->GetIsolate(), int_value + 1)); v8::Integer::New(script_state->GetIsolate(), int_value + 1));
} }
}; };
...@@ -3047,7 +3038,8 @@ ScriptPromise Internals::createRejectedPromise(ScriptState* script_state, ...@@ -3047,7 +3038,8 @@ ScriptPromise Internals::createRejectedPromise(ScriptState* script_state,
ScriptPromise Internals::addOneToPromise(ScriptState* script_state, ScriptPromise Internals::addOneToPromise(ScriptState* script_state,
ScriptPromise promise) { ScriptPromise promise) {
return promise.Then(AddOneFunction::CreateFunction(script_state)); return promise.Then(MakeGarbageCollected<NewScriptFunction>(
script_state, MakeGarbageCollected<AddOneFunction>()));
} }
ScriptPromise Internals::promiseCheck(ScriptState* script_state, ScriptPromise Internals::promiseCheck(ScriptState* script_state,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment