Commit 13b60e60 authored by Maksim Ivanov's avatar Maksim Ivanov Committed by Commit Bot

Fix use-after-move in blink/renderer/core/html/canvas/

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I83edc3ba736db0a5beece82166906b4a1478921c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401342Reviewed-by: default avatarFernando Serboncini <fserb@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805746}
parent efc06cb5
...@@ -128,7 +128,7 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider3D() { ...@@ -128,7 +128,7 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider3D() {
DCHECK(LowLatencyEnabled()); DCHECK(LowLatencyEnabled());
provider = CanvasResourceProvider::CreatePassThroughProvider( provider = CanvasResourceProvider::CreatePassThroughProvider(
Size(), FilterQuality(), ColorParams(), Size(), FilterQuality(), ColorParams(),
SharedGpuContext::ContextProviderWrapper(), std::move(dispatcher), SharedGpuContext::ContextProviderWrapper(), dispatcher,
RenderingContext()->IsOriginTopLeft()); RenderingContext()->IsOriginTopLeft());
} }
if (!provider) { if (!provider) {
...@@ -168,8 +168,7 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider3D() { ...@@ -168,8 +168,7 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider3D() {
if (!provider) { if (!provider) {
provider = CanvasResourceProvider::CreateSharedBitmapProvider( provider = CanvasResourceProvider::CreateSharedBitmapProvider(
Size(), FilterQuality(), ColorParams(), Size(), FilterQuality(), ColorParams(),
CanvasResourceProvider::ShouldInitialize::kCallClear, CanvasResourceProvider::ShouldInitialize::kCallClear, dispatcher);
std::move(dispatcher));
} }
if (!provider) { if (!provider) {
provider = CanvasResourceProvider::CreateBitmapProvider( provider = CanvasResourceProvider::CreateBitmapProvider(
...@@ -209,7 +208,7 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider2D( ...@@ -209,7 +208,7 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider2D(
provider = CanvasResourceProvider::CreateSwapChainProvider( provider = CanvasResourceProvider::CreateSwapChainProvider(
Size(), FilterQuality(), ColorParams(), Size(), FilterQuality(), ColorParams(),
CanvasResourceProvider::ShouldInitialize::kCallClear, CanvasResourceProvider::ShouldInitialize::kCallClear,
SharedGpuContext::ContextProviderWrapper(), std::move(dispatcher), SharedGpuContext::ContextProviderWrapper(), dispatcher,
is_origin_top_left); is_origin_top_left);
} }
// If SwapChain failed or it was not possible, we will try a SharedImage // If SwapChain failed or it was not possible, we will try a SharedImage
...@@ -258,8 +257,7 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider2D( ...@@ -258,8 +257,7 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider2D(
if (!provider) { if (!provider) {
provider = CanvasResourceProvider::CreateSharedBitmapProvider( provider = CanvasResourceProvider::CreateSharedBitmapProvider(
Size(), FilterQuality(), ColorParams(), Size(), FilterQuality(), ColorParams(),
CanvasResourceProvider::ShouldInitialize::kCallClear, CanvasResourceProvider::ShouldInitialize::kCallClear, dispatcher);
std::move(dispatcher));
} }
if (!provider) { if (!provider) {
provider = CanvasResourceProvider::CreateBitmapProvider( provider = CanvasResourceProvider::CreateBitmapProvider(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment