WebUI NTP: redirect sign-in to chrome://newtab

Bug: 1015293
Change-Id: Ic76e7911403a925fa46a5b5fc58eca95fa292269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209392
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771116}

chrome/browser/signin/dice_browsertest.cc

@@ -934,7 +934,7 @@ IN_PROC_BROWSER_TEST_F(DiceBrowserTest, MAYBE_EnableSyncBeforeToken) {
             dice_request_header_);
 
   ui_test_utils::UrlLoadObserver ntp_url_observer(
-      GURL(chrome::kChromeSearchLocalNtpUrl),
+      GURL(chrome::kChromeUINewTabURL),
       content::NotificationService::AllSources());
 
   WaitForSigninSucceeded();

chrome/browser/signin/process_dice_header_delegate_impl.cc

@@ -24,7 +24,7 @@ namespace {
 void RedirectToNtp(content::WebContents* contents) {
   VLOG(1) << "RedirectToNtp";
   contents->GetController().LoadURL(
-      GURL(chrome::kChromeSearchLocalNtpUrl), content::Referrer(),
+      GURL(chrome::kChromeUINewTabURL), content::Referrer(),
       ui::PAGE_TRANSITION_AUTO_TOPLEVEL, std::string());
 }
 

chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc

@@ -240,9 +240,8 @@ TEST_P(ProcessDiceHeaderDelegateImplTestEnableSync, EnableSync) {
       CreateDelegateAndNavigateToSignin(GetParam().signin_tab);
   delegate->EnableSync(account_id_);
   EXPECT_EQ(GetParam().callback_called, enable_sync_called_);
-  GURL expected_url = GetParam().show_ntp
-                          ? GURL(chrome::kChromeSearchLocalNtpUrl)
-                          : signin_url_;
+  GURL expected_url =
+      GetParam().show_ntp ? GURL(chrome::kChromeUINewTabURL) : signin_url_;
   EXPECT_EQ(expected_url, web_contents()->GetVisibleURL());
   EXPECT_FALSE(show_error_called_);
   // Check that the sync signin flow is complete.
@@ -283,9 +282,8 @@ TEST_P(ProcessDiceHeaderDelegateImplTestHandleTokenExchangeFailure,
   delegate->HandleTokenExchangeFailure(email_, auth_error_);
   EXPECT_FALSE(enable_sync_called_);
   EXPECT_EQ(GetParam().callback_called, show_error_called_);
-  GURL expected_url = GetParam().show_ntp
-                          ? GURL(chrome::kChromeSearchLocalNtpUrl)
-                          : signin_url_;
+  GURL expected_url =
+      GetParam().show_ntp ? GURL(chrome::kChromeUINewTabURL) : signin_url_;
   EXPECT_EQ(expected_url, web_contents()->GetVisibleURL());
   // Check that the sync signin flow is complete.
   if (GetParam().signin_tab) {