Commit 1442df78 authored by littledan's avatar littledan Committed by Commit bot

Thread up UseCounters for a few new metrics from V8

The metrics were added in the V8 patch reviewed at
https://codereview.chromium.org/1558113002
They measure
- Each of the three deprecated Promise functions
- Two nonstandard pieces of Intl functionality
- Accesses of the RegExp.prototype.unicode getter on the prototype

BUG=v8:3785,v8:3238,v8:4633

Review URL: https://codereview.chromium.org/1578143002

Cr-Commit-Position: refs/heads/master@{#371473}
parent 013af3f0
......@@ -86,6 +86,27 @@ static void useCounterCallback(v8::Isolate* isolate, v8::Isolate::UseCounterFeat
case v8::Isolate::kRegExpPrototypeToString:
blinkFeature = UseCounter::V8RegExpPrototypeToString;
break;
case v8::Isolate::kRegExpPrototypeUnicodeGetter:
blinkFeature = UseCounter::V8RegExpPrototypeUnicodeGetter;
break;
case v8::Isolate::kIntlV8Parse:
blinkFeature = UseCounter::V8IntlV8Parse;
break;
case v8::Isolate::kIntlPattern:
blinkFeature = UseCounter::V8IntlPattern;
break;
case v8::Isolate::kIntlResolved:
blinkFeature = UseCounter::V8IntlResolved;
break;
case v8::Isolate::kPromiseChain:
blinkFeature = UseCounter::V8PromiseChain;
break;
case v8::Isolate::kPromiseAccept:
blinkFeature = UseCounter::V8PromiseAccept;
break;
case v8::Isolate::kPromiseDefer:
blinkFeature = UseCounter::V8PromiseDefer;
break;
default:
// This can happen if V8 has added counters that this version of Blink
// does not know about. It's harmless.
......
......@@ -987,6 +987,13 @@ public:
ContentEditableTrue = 1130,
ContentEditableTrueOnHTML = 1131,
ContentEditablePlainTextOnly = 1132,
V8RegExpPrototypeUnicodeGetter = 1133,
V8IntlV8Parse = 1134,
V8IntlPattern = 1135,
V8IntlResolved = 1136,
V8PromiseChain = 1137,
V8PromiseAccept = 1138,
V8PromiseDefer = 1139,
// Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots.
......
......@@ -65777,6 +65777,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="1119" label="MediaDevicesEnumerateDevices"/>
<int value="1120" label="NonSecureSharedWorkerAccessedFromSecureContext"/>
<int value="1121" label="SecureSharedWorkerAccessedFromNonSecureContext"/>
<int value="1122" label="NonCSSStyleSheetType"/>
<int value="1123" label="EventDeepPath"/>
<int value="1124" label="LinkHeaderPreload"/>
<int value="1125" label="MouseWheelEvent"/>
<int value="1126" label="WheelEvent"/>
<int value="1127" label="MouseWheelAndWheelEvent"/>
<int value="1128" label="BodyScrollsInAdditionToViewport"/>
<int value="1129" label="DocumentDesignModeEnabeld"/>
<int value="1130" label="ContentEditableTrue"/>
<int value="1131" label="ContentEditableTrueOnHTML"/>
<int value="1132" label="ContentEditablePlainTextOnly"/>
<int value="1133" label="V8RegExpPrototypeUnicodeGetter"/>
<int value="1134" label="V8IntlV8Parse"/>
<int value="1135" label="V8IntlPattern"/>
<int value="1136" label="V8IntlResolved"/>
<int value="1137" label="V8PromiseChain"/>
<int value="1138" label="V8PromiseAccept"/>
<int value="1139" label="V8PromiseDefer"/>
</enum>
<enum name="FetchRequestMode" type="int">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment