2009-04-13 Darin Adler <darin@apple.com>

        Reviewed by Mark Rowe.

        * Scripts/check-for-exit-time-destructors: Add ERROR: and WARNING: prefixes to
        make these scripts work better with the build window in new versions of Xcode.
        * Scripts/check-for-global-initializers: Ditto.
        * Scripts/check-for-weak-vtables: Ditto.



git-svn-id: svn://svn.chromium.org/blink/trunk@42469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/WebKitTools/ChangeLog

+2009-04-13  Darin Adler  <darin@apple.com>
+
+        Reviewed by Mark Rowe.
+
+        * Scripts/check-for-exit-time-destructors: Add ERROR: and WARNING: prefixes to
+        make these scripts work better with the build window in new versions of Xcode.
+        * Scripts/check-for-global-initializers: Ditto.
+        * Scripts/check-for-weak-vtables: Ditto.
+
 2009-04-13  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Sam Weinig.

third_party/WebKit/WebKitTools/Scripts/check-for-exit-time-destructors

@@ -58,7 +58,7 @@ my $scriptAge = -M $0;
 my $list = $ENV{"LINK_FILE_LIST_${variant}_${arch}"};
 
 if (!open LIST, $list) {
-    print "Could not open $list\n";
+    print "ERROR: Could not open $list\n";
     exit 1;
 }
 
@@ -74,7 +74,7 @@ for my $file (sort @files) {
         next if defined $fileAge && $fileAge > $buildTimestampAge;
     }
     if (!open NM, "(nm '$file' | sed 's/^/STDOUT:/') 2>&1 |") {
-        print "Could not open $file\n";
+        print "ERROR: Could not open $file\n";
         $sawError = 1;
         next;
     }
@@ -96,7 +96,7 @@ for my $file (sort @files) {
 }
 
 if ($sawError and !$coverageBuild) {
-    print "Use DEFINE_STATIC_LOCAL from <wtf/StdLibExtras.h>\n";
+    print "ERROR: Use DEFINE_STATIC_LOCAL from <wtf/StdLibExtras.h>\n";
     unlink $executablePath;
     exit 1;
 }
@@ -115,7 +115,7 @@ sub demangle($)
 {
     my ($symbol) = @_;
     if (!open FILT, "c++filt $symbol |") {
-        print "Could not open c++filt\n";
+        print "ERROR: Could not open c++filt\n";
         return;
     }
     my $result = <FILT>;
@@ -128,7 +128,7 @@ sub printFunctions($$)
 {
     my ($shortName, $path) = @_;
     if (!open OTOOL, "otool -tV '$path' |") {
-        print "Could not open $path\n";
+        print "WARNING: Could not open $path\n";
         return 0;
     }
     my %functions;
@@ -142,10 +142,10 @@ sub printFunctions($$)
     my $result = 0;
     for my $function (sort keys %functions) {
         if (!$result) {
-            print "$shortName has exit time destructors in it! ($path)\n";
+            print "ERROR: $shortName has exit time destructors in it! ($path)\n";
             $result = 1;
         }
-        print "    $function\n";
+        print "ERROR: In function $function\n";
     }
     return $result;
 }

third_party/WebKit/WebKitTools/Scripts/check-for-global-initializers

@@ -57,7 +57,7 @@ my $scriptAge = -M $0;
 my $list = $ENV{"LINK_FILE_LIST_${variant}_${arch}"};
 
 if (!open LIST, $list) {
-    print "Could not open $list\n";
+    print "ERROR: Could not open $list\n";
     exit 1;
 }
 
@@ -73,7 +73,7 @@ for my $file (sort @files) {
         next if defined $fileAge && $fileAge > $buildTimestampAge;
     }
     if (!open NM, "(nm '$file' | sed 's/^/STDOUT:/') 2>&1 |") {
-        print "Could not open $file\n";
+        print "ERROR: Could not open $file\n";
         $sawError = 1;
         next;
     }
@@ -114,7 +114,7 @@ for my $file (sort @files) {
             }
         }
 
-        print "$shortName has a global initializer in it! ($file)\n";
+        print "ERROR: $shortName has a global initializer in it! ($file)\n";
         $sawError = 1;
     }
 }

third_party/WebKit/WebKitTools/Scripts/check-for-weak-vtables

@@ -58,7 +58,7 @@ my $sawError = 0;
 
 if (!defined $executablePathAge || !defined $buildTimestampAge || $executablePathAge > $buildTimestampAge) {
     if (!open NM, "(nm -m '$executablePath' | c++filt | sed 's/^/STDOUT:/') 2>&1 |") {
-        print "Could not open $executablePath\n";
+        print "ERROR: Could not open $executablePath\n";
         $sawError = 1;
         next;
     }
@@ -75,10 +75,10 @@ if (!defined $executablePathAge || !defined $buildTimestampAge || $executablePat
         my $shortName = $executablePath;
         $shortName =~ s/.*\///;
 
-        print "$shortName has a weak vtable in it ($executablePath)\n";
-        print "Fix by making sure the first virtual function in each of these classes is not an inline:\n";
+        print "ERROR: $shortName has a weak vtable in it ($executablePath)\n";
+        print "ERROR: Fix by making sure the first virtual function in each of these classes is not an inline:\n";
         for my $class (sort @weakVTableClasses) {
-            print "    $class\n";
+            print "ERROR: class $class\n";
         }
         $sawError = 1;
     }