Commit 1445f647 authored by Ryan Landay's avatar Ryan Landay Committed by Commit Bot

Remove unused param from TypingCommand::InsertTextRunWithoutNewlines()

The select_insert_text param in this method is only ever called with false after
https://chromium-review.googlesource.com/c/chromium/src/+/801979.

Bug: 784039
Change-Id: I3c8d0176bfb6600605d42b83676341a61fd83aac
Reviewed-on: https://chromium-review.googlesource.com/820352
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: default avatarXiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523251}
parent b531336e
......@@ -595,7 +595,7 @@ void TypingCommand::InsertText(const String& text,
text_to_insert_ = text;
if (text.IsEmpty()) {
InsertTextRunWithoutNewlines(text, false, editing_state);
InsertTextRunWithoutNewlines(text, editing_state);
return;
}
size_t selection_start = selection_start_;
......@@ -605,7 +605,7 @@ void TypingCommand::InsertText(const String& text,
if (newline > offset) {
const size_t insertion_length = newline - offset;
InsertTextRunWithoutNewlines(text.Substring(offset, insertion_length),
false, editing_state);
editing_state);
if (editing_state->IsAborted())
return;
......@@ -626,7 +626,7 @@ void TypingCommand::InsertText(const String& text,
if (text.length() > offset) {
const size_t insertion_length = text.length() - offset;
InsertTextRunWithoutNewlines(text.Substring(offset, insertion_length),
false, editing_state);
editing_state);
if (editing_state->IsAborted())
return;
......@@ -659,7 +659,6 @@ void TypingCommand::InsertText(const String& text,
}
void TypingCommand::InsertTextRunWithoutNewlines(const String& text,
bool select_inserted_text,
EditingState* editing_state) {
CompositeEditCommand* command;
if (IsIncrementalInsertion()) {
......
......@@ -93,7 +93,6 @@ class CORE_EXPORT TypingCommand final : public CompositeEditCommand {
void InsertText(const String& text, bool select_inserted_text, EditingState*);
void InsertTextRunWithoutNewlines(const String& text,
bool select_inserted_text,
EditingState*);
void InsertLineBreak(EditingState*);
void InsertParagraphSeparatorInQuotedContent(EditingState*);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment